[GitHub] [airflow] orossini commented on a change in pull request #17182: dataflowjobstatus sensor dag example fixed for issue #17180

[GitBox <gi...@apache.org>]

orossini commented on a change in pull request #17182:
URL: https://github.com/apache/airflow/pull/17182#discussion_r677026322



##########
File path: airflow/providers/google/cloud/example_dags/example_dataflow.py
##########
@@ -166,7 +166,7 @@
     # [START howto_sensor_wait_for_job_status]
     wait_for_python_job_async_done = DataflowJobStatusSensor(
         task_id="wait-for-python-job-async-done",
-        job_id="{{task_instance.xcom_pull('start-python-job-async')['job_id']}}",
+        job_id="{{task_instance.xcom_pull('start-python-job-async')['id']}}",

Review comment:
       You're right. However there is an issue for DataflowTemplatedJobStartOperator. The XCom doesn't have any job_id attribute.
   To solve this, the operators/dataflow.py can be updated for DataflowTemplatedJobStartOperator (as well as flextemplateJob and sqlJob operators): return job_id instead of job.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org