[jira] [Comment Edited] (HBASE-25751) Add writable TimeToPurgeDeletes to ScanOptions

["Andrew Kyle Purtell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-25751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317555#comment-17317555 ] 

Andrew Kyle Purtell edited comment on HBASE-25751 at 4/9/21, 12:35 AM:
-----------------------------------------------------------------------

I approved the PR. Looking at past practice, these options went in on new minors (2.3.0 for HBASE-24321 and 2.0.0 for HBASE-19895). Set fix versions to [ 2.5.0, 3.0.0-alpha ] accordingly to start.

ScanInfo is the user facing class modified here. It is LimitedPrivate(COPROC). Per our compatibility guidelines at http://hbase.apache.org/book.html#hbase.versioning:

{quote}
APIs available in a patch version will be available in *all later patch versions*. However, new APIs may be added which will not be available in earlier patch versions.

New APIs introduced in a patch version will only be added in a source compatible way [1]: i.e. code that implements public APIs will continue to compile.
{quote}

Given this guidance I think this can go in to branch-2.4 for inclusion in 2.4.3 as well. Anyone have any objection to this? 


was (Author: apurtell):
I approved the PR. Looking at past practice, these options went in on new minors (2.3.0 for HBASE-24321 and 2.0.0 for HBASE-19895). Set fix versions to { 2.5.0, 3.0.0-alpha } accordingly to start.

ScanInfo is the user facing class modified here. It is LimitedPrivate(COPROC). Per our compatibility guidelines at http://hbase.apache.org/book.html#hbase.versioning:

{quote}
APIs available in a patch version will be available in *all later patch versions*. However, new APIs may be added which will not be available in earlier patch versions.

New APIs introduced in a patch version will only be added in a source compatible way [1]: i.e. code that implements public APIs will continue to compile.
{quote}

Given this guidance I think this can go in to branch-2.4 for inclusion in 2.4.3 as well. Anyone have any objection to this? 

> Add writable TimeToPurgeDeletes to ScanOptions
> ----------------------------------------------
>
>                 Key: HBASE-25751
>                 URL: https://issues.apache.org/jira/browse/HBASE-25751
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> In HBase 1.x and before, it was possible to override all settings on the ScanInfo when overriding the flush and compaction scanner open coprocoessors. HBase 2.x changed the coprocessor model to instead allow changes to a limited set of options on the ScanOptions object.  
> In HBASE-19895 and HBASE-24321, we added support for KeepDeletedCells and MinVersions to be overriden by ScanOptions, as needed by Phoenix. 
> A 1.x coprocessor used at my day job overrides TimeToPurgeDeletes, and to convert it to HBase 2.x that property would need to be overridable from ScanOptions as well. This should be a straightforward extension of the previous work. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)