You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Toshiaki Hatano <ha...@haeena.net> on 2013/11/01 02:28:19 UTC
Re: Review Request 15068: Change labels for VLAN to vNet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review27992
-----------------------------------------------------------
I suppose this should be reviewed by UI devs too.
Could you add UI devs in reviewers?
- Toshiaki Hatano
On Oct. 30, 2013, 8:46 p.m., Chris Cameron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 8:46 p.m.)
>
>
> Review request for cloudstack and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 3210aca
> ui/dictionary.jsp 35cba22
> ui/scripts/network.js 12e5389
> ui/scripts/system.js 479883c
>
> Diff: https://reviews.apache.org/r/15068/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Cameron
>
>
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Toshiaki Hatano <ha...@haeena.net>.
> On Nov. 1, 2013, 1:28 a.m., Toshiaki Hatano wrote:
> > I suppose this should be reviewed by UI devs too.
> > Could you add UI devs in reviewers?
Other than that, this patch looks OK for me.
But this patch makes changes in UI, so I suppose it's better to check with UI ppl.
- Toshiaki
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15068/#review27992
-----------------------------------------------------------
On Oct. 30, 2013, 8:46 p.m., Chris Cameron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 8:46 p.m.)
>
>
> Review request for cloudstack and Toshiaki Hatano.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>
>
> Diffs
> -----
>
> client/WEB-INF/classes/resources/messages.properties 3210aca
> ui/dictionary.jsp 35cba22
> ui/scripts/network.js 12e5389
> ui/scripts/system.js 479883c
>
> Diff: https://reviews.apache.org/r/15068/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Cameron
>
>
Re: Review Request 15068: Change labels for VLAN to vNet
Posted by Sebastien Goasguen <ru...@gmail.com>.
Pinging Jessica and Brian on this review,
On Oct 31, 2013, at 9:28 PM, Toshiaki Hatano <ha...@haeena.net> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15068/#review27992
> -----------------------------------------------------------
>
>
> I suppose this should be reviewed by UI devs too.
> Could you add UI devs in reviewers?
>
> - Toshiaki Hatano
>
>
> On Oct. 30, 2013, 8:46 p.m., Chris Cameron wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/15068/
>> -----------------------------------------------------------
>>
>> (Updated Oct. 30, 2013, 8:46 p.m.)
>>
>>
>> Review request for cloudstack and Toshiaki Hatano.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> We would like to change the labels for VLAN to vNet to make the term more generic for VXLAN and VLAN. This relates to the work being done to add in VXLAN support to Cloudstack.
>>
>>
>> Diffs
>> -----
>>
>> client/WEB-INF/classes/resources/messages.properties 3210aca
>> ui/dictionary.jsp 35cba22
>> ui/scripts/network.js 12e5389
>> ui/scripts/system.js 479883c
>>
>> Diff: https://reviews.apache.org/r/15068/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Chris Cameron
>>
>>
>