[GitHub] [beam] yifanmai commented on a change in pull request #12605: Copy subtransforms to output of translations.pipeline_from_stages()

[GitBox <gi...@apache.org>]

yifanmai commented on a change in pull request #12605:
URL: https://github.com/apache/beam/pull/12605#discussion_r474274784



##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -524,6 +524,22 @@ def add_parent(child, parent):
         add_parent(parent, parents.get(parent))
       components.transforms[parent].subtransforms.append(child)
 
+  copied_subtransform_ids = set()

Review comment:
       Thanks! This simplifies things.

##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -541,6 +557,14 @@ def add_parent(child, parent):
     components.transforms[transform_id].CopyFrom(transform)
     add_parent(transform_id, stage.parent)
 
+  if partial:

Review comment:
       Moved it back up and cleaned up the method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org