You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/15 12:37:43 UTC
[GitHub] [iceberg] szlta opened a new pull request, #5536: SetSnapshotOperation should commit empty operations too
szlta opened a new pull request, #5536:
URL: https://github.com/apache/iceberg/pull/5536
As discussed in #5507 SetSnapshotOperation currently doesn't commit the operation if the metadata is unchanged. Since this is used in a transaction, it can result in failure of committing the whole transaction as the `hasLastOpCommited` was not advanced.
I propose we commit such empty operations, as the overall transaction commit will result in a no-op anyway in these cases.
cc: @kbendick @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] szlta commented on pull request #5536: SetSnapshotOperation should commit empty operations too
Posted by GitBox <gi...@apache.org>.
szlta commented on PR #5536:
URL: https://github.com/apache/iceberg/pull/5536#issuecomment-1216543466
Thanks for the review everyone, and Ryan for approving and merging this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5536: SetSnapshotOperation should commit empty operations too
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5536:
URL: https://github.com/apache/iceberg/pull/5536#issuecomment-1215693269
I think this change looks good. If we are going to suppress a commit, then it probably makes sense to detect that the metadata has not changed in `TableOperations` rather than not calling commit in the operation itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5536: SetSnapshotOperation should commit empty operations too
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5536:
URL: https://github.com/apache/iceberg/pull/5536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org