You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/01/19 09:03:22 UTC

[GitHub] sijie commented on issue #1018: Issue1007: move checksum to proto

sijie commented on issue #1018: Issue1007: move checksum to proto
URL: https://github.com/apache/bookkeeper/pull/1018#issuecomment-358906160
 
 
   @ArvinDevel 
   
   I saw your question in the other PR. but didn't get a chance to reply. I will reply here:
   
   `client.api` is the new API package, which is going to the bookkeeper api in future. the old api will be deprecated in future releases soon. so now we have 3 types of DigestType in the project.
   
   `client.api.DigestType` is the user facing one, `bookkeeper.DigestType' is from the old one, `proto.DigestType` is the one used for storing the metadata. you can't change the `bookkeeper.DigestType` in the old api, because it is there for backward compatability. so I would suggest:
   
   - leave `client.api.DigestType` there, because it is the user facing api.
   - leave `bookkeeper.DigestType` there for BC reason. (it will be gone soon).
   - in the remaining places, use the `proto.DigestType`, which means DigestManager uses `proto.DigestType`. 
   
   does this make sense to you?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services