You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/16 01:44:00 UTC

[GitHub] [flink] luoyuxia opened a new pull request, #19727: [FLINK-27617][sql] Flink supports CUME_DIST function

luoyuxia opened a new pull request, #19727:
URL: https://github.com/apache/flink/pull/19727

   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
   
   
   ## Brief change log
   
   *(for example:)*
     - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
     - *Deployments RPC transmits only the blob storage reference*
     - *TaskManagers retrieve the TaskInfo from the blob cache*
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia commented on pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #19727:
URL: https://github.com/apache/flink/pull/19727#issuecomment-1178453567

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia commented on pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #19727:
URL: https://github.com/apache/flink/pull/19727#issuecomment-1192093620

   @wuchong Thanks for review. I have updated this pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia commented on a diff in pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19727:
URL: https://github.com/apache/flink/pull/19727#discussion_r927605133


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/generated/AggsHandleFunction.java:
##########
@@ -36,4 +36,10 @@ public interface AggsHandleFunction extends AggsHandleFunctionBase {
      * @return the final result (saved in a row) of the current accumulators.
      */
     RowData getValue() throws Exception;
+
+    /**
+     * Set window size for the aggregate function. Some aggregate functions may requires the size of
+     * current window to do calculation.
+     */

Review Comment:
   done.



##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala:
##########
@@ -320,6 +326,7 @@ class AggsHandlerCodeGenerator(
     initialAggregateInformation(aggInfoList)
 
     // generates all methods body first to add necessary reuse code to context
+    val setWindowSizeCode = if (isWindowSizeNeeded) genSetWindowSize() else ""

Review Comment:
   Based on the current implementation, we will always call method `setWindowSize`, so we can't generate the code to  throw exception . But I add some comments for this method  `genSetWindowSize`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia commented on a diff in pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19727:
URL: https://github.com/apache/flink/pull/19727#discussion_r927220287


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/DistinctAggCodeGen.scala:
##########
@@ -955,4 +956,9 @@ class DistinctAggCodeGen(
        """.stripMargin
     }
   }
+
+  override def setWindowSize(generator: ExprCodeGenerator): String = {
+    throw new TableException(
+      "Distinct shouldn't set window size, this is a bug, please file a issue.")

Review Comment:
   No, currently, the dictinct + over is not supported, see the [code](https://github.com/apache/flink/blob/bf342d2f67a46e5266c3595734574db270f1b48c/flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/batch/BatchPhysicalOverAggregateRule.scala#L209).
   Also, in this pr, it'll [skip](https://github.com/apache/flink/pull/19727/files#diff-04af992db6ef031313241dbb2fc6d1bc6bf8b75b8b7b98d2effeb101fbe17e36R870) `setWindowSize` when it's  for `DistinctAggCodeGen`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19727: [FLINK-27617][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19727:
URL: https://github.com/apache/flink/pull/19727#issuecomment-1127130573

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "de81e44659669684a306da9817d8c90c5b11927f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "de81e44659669684a306da9817d8c90c5b11927f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * de81e44659669684a306da9817d8c90c5b11927f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia commented on a diff in pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19727:
URL: https://github.com/apache/flink/pull/19727#discussion_r927218243


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/SizeBasedWindowFunction.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.aggfunctions;
+
+import org.apache.flink.table.expressions.UnresolvedReferenceExpression;
+
+/**
+ * Some functions like CUME_DIST/PERCENT_RANK/NTILE need the size of current window for calculation.
+ * Such function need to implement the interface to provide accessing to the window size.
+ *
+ * <p>NOTE: Now, it can only be used by {@link DeclarativeAggregateFunction}.
+ */
+public interface SizeBasedWindowFunction {
+
+    /** The field for the window size. */
+    UnresolvedReferenceExpression windowSize();

Review Comment:
   Really a good suggestion!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia commented on a diff in pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19727:
URL: https://github.com/apache/flink/pull/19727#discussion_r927220287


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/DistinctAggCodeGen.scala:
##########
@@ -955,4 +956,9 @@ class DistinctAggCodeGen(
        """.stripMargin
     }
   }
+
+  override def setWindowSize(generator: ExprCodeGenerator): String = {
+    throw new TableException(
+      "Distinct shouldn't set window size, this is a bug, please file a issue.")

Review Comment:
   No, currently, the dictinct + over is not supported, see the [code](https://github.com/apache/flink/blob/bf342d2f67a46e5266c3595734574db270f1b48c/flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/batch/BatchPhysicalOverAggregateRule.scala#L209).
   Also, in this pr, it'll [skip][https://github.com/apache/flink/pull/19727/files#diff-04af992db6ef031313241dbb2fc6d1bc6bf8b75b8b7b98d2effeb101fbe17e36R870) `setWindowSize` when it's  for `DistinctAggCodeGen`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on a diff in pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
wuchong commented on code in PR #19727:
URL: https://github.com/apache/flink/pull/19727#discussion_r927371145


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala:
##########
@@ -320,6 +326,7 @@ class AggsHandlerCodeGenerator(
     initialAggregateInformation(aggInfoList)
 
     // generates all methods body first to add necessary reuse code to context
+    val setWindowSizeCode = if (isWindowSizeNeeded) genSetWindowSize() else ""

Review Comment:
   Please follow the way of `genRetract()` to generate throw exception when window size is not needed. 



##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/generated/AggsHandleFunction.java:
##########
@@ -36,4 +36,10 @@ public interface AggsHandleFunction extends AggsHandleFunctionBase {
      * @return the final result (saved in a row) of the current accumulators.
      */
     RowData getValue() throws Exception;
+
+    /**
+     * Set window size for the aggregate function. Some aggregate functions may requires the size of
+     * current window to do calculation.
+     */

Review Comment:
   Add more explanation about the "window size", it may confuse devs the relationship with tumble/hop window size.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia commented on a diff in pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #19727:
URL: https://github.com/apache/flink/pull/19727#discussion_r927218360


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggCodeGen.scala:
##########
@@ -46,5 +48,6 @@ trait AggCodeGen {
       needRetract: Boolean = false,
       needMerge: Boolean = false,
       needReset: Boolean = false,
-      needEmitValue: Boolean = false): Unit
+      needEmitValue: Boolean = false,
+      needWindowSize: Boolean = false): Unit

Review Comment:
   Miss it. Now I have removed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on a diff in pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
wuchong commented on code in PR #19727:
URL: https://github.com/apache/flink/pull/19727#discussion_r919976481


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/expressions/DeclarativeExpressionResolver.java:
##########
@@ -58,6 +59,10 @@ protected ResolvedExpression defaultMethod(Expression expression) {
         if (expression instanceof UnresolvedReferenceExpression) {
             UnresolvedReferenceExpression expr = (UnresolvedReferenceExpression) expression;
             String name = expr.getName();
+            if (function instanceof SizeBasedWindowFunction

Review Comment:
   TODO



##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/SizeBasedWindowFunction.java:
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.aggfunctions;
+
+import org.apache.flink.table.expressions.UnresolvedReferenceExpression;
+
+/**
+ * Some functions like CUME_DIST/PERCENT_RANK/NTILE need the size of current window for calculation.
+ * Such function need to implement the interface to provide accessing to the window size.
+ *
+ * <p>NOTE: Now, it can only be used by {@link DeclarativeAggregateFunction}.
+ */
+public interface SizeBasedWindowFunction {
+
+    /** The field for the window size. */
+    UnresolvedReferenceExpression windowSize();

Review Comment:
   A window function should have only a context-provided window size expression. So we don't need to let users define the expression. The interface can pre-define one. In addition, the expression can be a resolved one, to make it easy to use when code generation (don't need `toWindowSizeExpr`). For example:
   
   ```java
   default ResolvedExpression windowSizeAttribute() {
           return localRef("window_size", DataTypes.INT());
   }
   ```
   
   Then devs dont' need to implement this method and can directly be used just like method `operand(i)`.



##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/AggCodeGenHelper.scala:
##########
@@ -280,6 +281,11 @@ object AggCodeGenHelper {
       val variableName = s"agg${aggIndex}_$name"
       newLocalReference(variableName, aggBufferTypes(aggIndex)(localIndex))
     }
+
+    override def toWindowSizeExpr(name: String): ResolvedExpression = {
+      val variableName = s"agg${aggIndex}_$name"

Review Comment:
   We may not need this when the windowSize expression is resolved. 



##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/generated/AggsFunctionWithWindowSize.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.generated;
+
+/**
+ * The interface to provide the ability to set window size for the aggregate functions that requires
+ * the size of current window to do calculation.
+ *
+ * <p>It is code generated to set the size of current window
+ */
+public interface AggsFunctionWithWindowSize {
+    void setWindowSize(int windowSize);

Review Comment:
   I think it's fine to just put this method in `AggsHandleFunction` or `AggsHandleFunctionBase`. When generating handle for the non-window-sized function, the method can just be a no-op, like `retract`, `merge`, `reset` methods. 



##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggCodeGen.scala:
##########
@@ -46,5 +48,6 @@ trait AggCodeGen {
       needRetract: Boolean = false,
       needMerge: Boolean = false,
       needReset: Boolean = false,
-      needEmitValue: Boolean = false): Unit
+      needEmitValue: Boolean = false,
+      needWindowSize: Boolean = false): Unit

Review Comment:
   We don't need to add `needWindowSize` check here (and you didn't use it at all), because the `checkNeededMethods` just happens on imperative aggregate functions, and the window size method is generated only for declarative agg functions. 



##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/generated/AggsFunctionWithWindowSize.java:
##########
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.generated;
+
+/**
+ * The interface to provide the ability to set window size for the aggregate functions that requires
+ * the size of current window to do calculation.
+ *
+ * <p>It is code generated to set the size of current window
+ */
+public interface AggsFunctionWithWindowSize {
+    void setWindowSize(int windowSize);

Review Comment:
   I think it's fine to just put this method in `AggsHandleFunction` or `AggsHandleFunctionBase`. When generating handle for the non-window-sized function, the method can just be a no-op, like `retract`, `merge`, `reset` methods. 



##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/OverAggregateITCase.scala:
##########
@@ -2759,6 +2758,53 @@ class OverAggregateITCase extends BatchTestBase {
       "select dep,name,rank() over (partition by dep order by salary desc) as rnk from emp",
       Seq(row("1", "A", 2), row("1", "B", 1), row("2", "C", 1)))
   }
+
+  @Test
+  def testCumeDist(): Unit = {

Review Comment:
   Please add additional tests to cover values of order-key containing duplicates. 



##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/DistinctAggCodeGen.scala:
##########
@@ -955,4 +956,9 @@ class DistinctAggCodeGen(
        """.stripMargin
     }
   }
+
+  override def setWindowSize(generator: ExprCodeGenerator): String = {
+    throw new TableException(
+      "Distinct shouldn't set window size, this is a bug, please file a issue.")

Review Comment:
   Is it possible that `COUNT(DISTINCT) OVER ...` may hit this?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong merged pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
wuchong merged PR #19727:
URL: https://github.com/apache/flink/pull/19727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia commented on pull request #19727: [FLINK-27618][sql] Flink supports CUME_DIST function

Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #19727:
URL: https://github.com/apache/flink/pull/19727#issuecomment-1173307574

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org