You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/05 00:02:28 UTC

[kudu-CR] tablet server-test: deflake ScanCorruptedDeltasParamTest 

Hello Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14375

to review the following change.


Change subject: tablet_server-test: deflake ScanCorruptedDeltasParamTest
......................................................................

tablet_server-test: deflake ScanCorruptedDeltasParamTest

Saw this in a precommit, though I could only repro it 1/10000 times using
dist-test, so it must be pretty rare. Normally scans on a failed tablet will
yield the error already expected in the test, but tablet failure is
asynchronous, so if we're doing snapshot scans, it's possible for the next
scan to see a running tablet, start the scan, and fail within
WaitForSnapshotWithAllCommitted because the async failure process hasn't yet
marked the entire tablet as failed.

  /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_server-test.cc:1840: Failure
        Expected: resp.error().status().code()
        Which is: 11
  To be equal to: AppStatusPB::ILLEGAL_STATE
        Which is: 9
  Google Test trace:
  /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_server-test.cc:1839: error {
    code: TABLET_FAILED
    status {
      code: ABORTED
      message: "MVCC is closed"
    }
  }

Change-Id: I51012fa5912e4ce6a2e8f1d370ac387df5bd6db6
---
M src/kudu/tserver/tablet_server-test.cc
1 file changed, 26 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/14375/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51012fa5912e4ce6a2e8f1d370ac387df5bd6db6
Gerrit-Change-Number: 14375
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>

[kudu-CR] tablet server-test: deflake ScanCorruptedDeltasParamTest

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14375 )

Change subject: tablet_server-test: deflake ScanCorruptedDeltasParamTest
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51012fa5912e4ce6a2e8f1d370ac387df5bd6db6
Gerrit-Change-Number: 14375
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 07 Oct 2019 23:55:15 +0000
Gerrit-HasComments: No

[kudu-CR] tablet server-test: deflake ScanCorruptedDeltasParamTest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14375 )

Change subject: tablet_server-test: deflake ScanCorruptedDeltasParamTest
......................................................................

tablet_server-test: deflake ScanCorruptedDeltasParamTest

Saw this in a precommit, though I could only repro it 1/10000 times using
dist-test, so it must be pretty rare. Normally scans on a failed tablet will
yield the error already expected in the test, but tablet failure is
asynchronous, so if we're doing snapshot scans, it's possible for the next
scan to see a running tablet, start the scan, and fail within
WaitForSnapshotWithAllCommitted because the async failure process hasn't yet
marked the entire tablet as failed.

  /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_server-test.cc:1840: Failure
        Expected: resp.error().status().code()
        Which is: 11
  To be equal to: AppStatusPB::ILLEGAL_STATE
        Which is: 9
  Google Test trace:
  /home/jenkins-slave/workspace/kudu-master/1/src/kudu/tserver/tablet_server-test.cc:1839: error {
    code: TABLET_FAILED
    status {
      code: ABORTED
      message: "MVCC is closed"
    }
  }

Change-Id: I51012fa5912e4ce6a2e8f1d370ac387df5bd6db6
Reviewed-on: http://gerrit.cloudera.org:8080/14375
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/tserver/tablet_server-test.cc
1 file changed, 26 insertions(+), 9 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14375
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I51012fa5912e4ce6a2e8f1d370ac387df5bd6db6
Gerrit-Change-Number: 14375
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)