You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by zimuzo ezeozue <zi...@gmail.com> on 2014/10/04 06:46:05 UTC
First bug
https://issues.apache.org/ooo/show_bug.cgi?id=125621
This is the first bug I'm working on, attached is a diff file for the bug.
Is this the correct way to submit changes?
I sent a mail to QA to give me bugzilla permissions to assign the bug to
myself so I can submit the patch. What do I do next?
Re: First bug
Posted by Andrea Pescetti <pe...@apache.org>.
Kay Schenk wrote:
> On Thu, Oct 23, 2014 at 12:11 AM, Andrea Pescetti wrote:
>> 2) All: Do we have a "canonical" way to attribute commits? ...
> What we have documented is on:
> http://openoffice.apache.org/svn-basics.html#committing_changes_by_others
> I had not been including the email addresses -- oops!. But, we should come
> up with a standard and use it. We should probably change the syntax for
> issue referencing.
Sure, that must be changed in our online documentation.
> Here's a list of "special fields" supported if we want to go into more fine
> tuning.
> http://subversion.apache.org/docs/community-guide/conventions.html#crediting
I believe that the #i123456# and "\nPatch by: Xxxx Yyyy
<zz...@example.org>" conventions will be enough for the time being. I've
sometimes used "Reported by" instead of the "official" (i.e., listed on
that page) "Found by", but this is minor.
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: First bug
Posted by Kay Schenk <ka...@gmail.com>.
On Thu, Oct 23, 2014 at 12:11 AM, Andrea Pescetti <pe...@apache.org>
wrote:
> On 07/10/2014 Kay Schenk wrote:
>
>> Your patch has now been committed to trunk and noted in the issue. Good
>> job! Please feel free to continue your work with us either in the Help
>> area or elsewhere.
>>
>
> Thanks Zimuzo for your first patch! Two things, one for Zimuzo and one
> generic:
>
> 1) Zimuzo, if you are still looking for a new issue just let us know: you
> can probably find plenty of suggestions for similar fixes in the l10n list
> archives http://markmail.org/search/list:org.apache.incubator.ooo-l10n
> but we can suggest specific ones if you prefer.
>
> 2) All: Do we have a "canonical" way to attribute commits? Ohloh, or
> whatever it's called now, will still be hopelessly broken (as a consequence
> of how attribution in SVN and GIT works) and misrepresent attribution, so
> 5-6 contributors are actually hidden behind the username "pescetti" because
> I committed their patches. In this case Kay http://svn.apache.org/viewvc?
> view=revision&revision=1629549 used "i125621 Patch by: zimuzo ezeosue".
> It is surely clear to a human reader. I wonder if we can make it easier to
> parse. For example, the issue reference should be #i125621# (with '#'
> signs) for our Bugzilla bot to see it and annotate the corresponding issue
> automatically. But do we have (or want) a standard for attribution? I tend,
> in general, to write something like
> ---
> #i999999# Fix problem with XYZ
> Patch-By: Xxxxxx Yyyyy <ma...@example.com>
> ---
> but I can change it to any other convention if we decide to adopt one.
>
> Regards,
> Andrea.
>
>
>
What we have documented is on:
http://openoffice.apache.org/svn-basics.html#committing_changes_by_others
I had not been including the email addresses -- oops!. But, we should come
up with a standard and use it. We should probably change the syntax for
issue referencing.
Here's a list of "special fields" supported if we want to go into more fine
tuning.
http://subversion.apache.org/docs/community-guide/conventions.html#crediting
--
-------------------------------------------------------------------------------------------------
MzK
"Success breeds complacency. Complacency breeds failure.
Only the paranoid survive."
-- Andy Grove, Intel Co-founder
Re: First bug
Posted by Andrea Pescetti <pe...@apache.org>.
On 07/10/2014 Kay Schenk wrote:
> Your patch has now been committed to trunk and noted in the issue. Good
> job! Please feel free to continue your work with us either in the Help
> area or elsewhere.
Thanks Zimuzo for your first patch! Two things, one for Zimuzo and one
generic:
1) Zimuzo, if you are still looking for a new issue just let us know:
you can probably find plenty of suggestions for similar fixes in the
l10n list archives
http://markmail.org/search/list:org.apache.incubator.ooo-l10n but we can
suggest specific ones if you prefer.
2) All: Do we have a "canonical" way to attribute commits? Ohloh, or
whatever it's called now, will still be hopelessly broken (as a
consequence of how attribution in SVN and GIT works) and misrepresent
attribution, so 5-6 contributors are actually hidden behind the username
"pescetti" because I committed their patches. In this case Kay
http://svn.apache.org/viewvc?view=revision&revision=1629549 used
"i125621 Patch by: zimuzo ezeosue". It is surely clear to a human
reader. I wonder if we can make it easier to parse. For example, the
issue reference should be #i125621# (with '#' signs) for our Bugzilla
bot to see it and annotate the corresponding issue automatically. But do
we have (or want) a standard for attribution? I tend, in general, to
write something like
---
#i999999# Fix problem with XYZ
Patch-By: Xxxxxx Yyyyy <ma...@example.com>
---
but I can change it to any other convention if we decide to adopt one.
Regards,
Andrea.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: First bug
Posted by Kay Schenk <ka...@gmail.com>.
Your patch has now been committed to trunk and noted in the issue. Good
job! Please feel free to continue your work with us either in the Help
area or elsewhere.
As always, it is recommended that you start form a clean build shell for
new builds.
Thanks again.
On Sat, Oct 4, 2014 at 10:23 AM, Kay Schenk <ka...@gmail.com> wrote:
> On Fri, Oct 3, 2014 at 10:02 PM, zimuzo ezeozue <zi...@gmail.com>
> wrote:
>
>> Ok.. Thanks
>>
>
> Thanks for the patch. We'll get this included in the next few days along
> with other changes to helpcontent2.
>
>
>>
>> On Sat, Oct 4, 2014 at 5:51 AM, Alexandro Colorado <jz...@oooes.org> wrote:
>>
>> > Please dont include the patch in the mailing list, the patch should be
>> > submitted in the bug report as an attachment type PATCH.
>> >
>> > http://www.bugzilla.org/docs/3.0/html/attachments.html
>> > http://www.hforge.org/docs/_images/bugzilla_add_patch/;download
>> >
>> > Regards.
>> >
>> > On 10/3/14, zimuzo ezeozue <zi...@gmail.com> wrote:
>> > > Sorry here is the attached file
>> > >
>> > > On Sat, Oct 4, 2014 at 5:46 AM, zimuzo ezeozue <
>> zimuzostanley@gmail.com>
>> > > wrote:
>> > >
>> > >> https://issues.apache.org/ooo/show_bug.cgi?id=125621
>> > >>
>> > >> This is the first bug I'm working on, attached is a diff file for the
>> > >> bug. Is this the correct way to submit changes?
>> > >>
>> > >>
>> > >> I sent a mail to QA to give me bugzilla permissions to assign the
>> bug
>> > to
>> > >> myself so I can submit the patch. What do I do next?
>> > >>
>> > >
>> >
>> >
>> > --
>> > Alexandro Colorado
>> > Apache OpenOffice Contributor
>> > 882C 4389 3C27 E8DF 41B9 5C4C 1DB7 9D1C 7F4C 2614
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
>> > For additional commands, e-mail: dev-help@openoffice.apache.org
>> >
>> >
>>
>
>
>
> --
>
> -------------------------------------------------------------------------------------------------
> MzK
>
> "The universe is full of magical things
> patiently waiting for our wits to grow sharper."
> -- Eden Phillpotts
>
--
-------------------------------------------------------------------------------------------------
MzK
"The universe is full of magical things
patiently waiting for our wits to grow sharper."
-- Eden Phillpotts
Re: First bug
Posted by Kay Schenk <ka...@gmail.com>.
On Fri, Oct 3, 2014 at 10:02 PM, zimuzo ezeozue <zi...@gmail.com>
wrote:
> Ok.. Thanks
>
Thanks for the patch. We'll get this included in the next few days along
with other changes to helpcontent2.
>
> On Sat, Oct 4, 2014 at 5:51 AM, Alexandro Colorado <jz...@oooes.org> wrote:
>
> > Please dont include the patch in the mailing list, the patch should be
> > submitted in the bug report as an attachment type PATCH.
> >
> > http://www.bugzilla.org/docs/3.0/html/attachments.html
> > http://www.hforge.org/docs/_images/bugzilla_add_patch/;download
> >
> > Regards.
> >
> > On 10/3/14, zimuzo ezeozue <zi...@gmail.com> wrote:
> > > Sorry here is the attached file
> > >
> > > On Sat, Oct 4, 2014 at 5:46 AM, zimuzo ezeozue <
> zimuzostanley@gmail.com>
> > > wrote:
> > >
> > >> https://issues.apache.org/ooo/show_bug.cgi?id=125621
> > >>
> > >> This is the first bug I'm working on, attached is a diff file for the
> > >> bug. Is this the correct way to submit changes?
> > >>
> > >>
> > >> I sent a mail to QA to give me bugzilla permissions to assign the bug
> > to
> > >> myself so I can submit the patch. What do I do next?
> > >>
> > >
> >
> >
> > --
> > Alexandro Colorado
> > Apache OpenOffice Contributor
> > 882C 4389 3C27 E8DF 41B9 5C4C 1DB7 9D1C 7F4C 2614
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> > For additional commands, e-mail: dev-help@openoffice.apache.org
> >
> >
>
--
-------------------------------------------------------------------------------------------------
MzK
"The universe is full of magical things
patiently waiting for our wits to grow sharper."
-- Eden Phillpotts
Re: First bug
Posted by zimuzo ezeozue <zi...@gmail.com>.
Ok.. Thanks
On Sat, Oct 4, 2014 at 5:51 AM, Alexandro Colorado <jz...@oooes.org> wrote:
> Please dont include the patch in the mailing list, the patch should be
> submitted in the bug report as an attachment type PATCH.
>
> http://www.bugzilla.org/docs/3.0/html/attachments.html
> http://www.hforge.org/docs/_images/bugzilla_add_patch/;download
>
> Regards.
>
> On 10/3/14, zimuzo ezeozue <zi...@gmail.com> wrote:
> > Sorry here is the attached file
> >
> > On Sat, Oct 4, 2014 at 5:46 AM, zimuzo ezeozue <zi...@gmail.com>
> > wrote:
> >
> >> https://issues.apache.org/ooo/show_bug.cgi?id=125621
> >>
> >> This is the first bug I'm working on, attached is a diff file for the
> >> bug. Is this the correct way to submit changes?
> >>
> >>
> >> I sent a mail to QA to give me bugzilla permissions to assign the bug
> to
> >> myself so I can submit the patch. What do I do next?
> >>
> >
>
>
> --
> Alexandro Colorado
> Apache OpenOffice Contributor
> 882C 4389 3C27 E8DF 41B9 5C4C 1DB7 9D1C 7F4C 2614
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>
Re: First bug
Posted by Alexandro Colorado <jz...@oooes.org>.
Please dont include the patch in the mailing list, the patch should be
submitted in the bug report as an attachment type PATCH.
http://www.bugzilla.org/docs/3.0/html/attachments.html
http://www.hforge.org/docs/_images/bugzilla_add_patch/;download
Regards.
On 10/3/14, zimuzo ezeozue <zi...@gmail.com> wrote:
> Sorry here is the attached file
>
> On Sat, Oct 4, 2014 at 5:46 AM, zimuzo ezeozue <zi...@gmail.com>
> wrote:
>
>> https://issues.apache.org/ooo/show_bug.cgi?id=125621
>>
>> This is the first bug I'm working on, attached is a diff file for the
>> bug. Is this the correct way to submit changes?
>>
>>
>> I sent a mail to QA to give me bugzilla permissions to assign the bug to
>> myself so I can submit the patch. What do I do next?
>>
>
--
Alexandro Colorado
Apache OpenOffice Contributor
882C 4389 3C27 E8DF 41B9 5C4C 1DB7 9D1C 7F4C 2614
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org
Re: First bug
Posted by zimuzo ezeozue <zi...@gmail.com>.
Sorry here is the attached file
On Sat, Oct 4, 2014 at 5:46 AM, zimuzo ezeozue <zi...@gmail.com>
wrote:
> https://issues.apache.org/ooo/show_bug.cgi?id=125621
>
> This is the first bug I'm working on, attached is a diff file for the
> bug. Is this the correct way to submit changes?
>
>
> I sent a mail to QA to give me bugzilla permissions to assign the bug to
> myself so I can submit the patch. What do I do next?
>