You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2021/07/07 13:40:56 UTC

[GitHub] [storm] FelixEngl edited a comment on pull request #3403: Fix python version check in storm.ps1

FelixEngl edited a comment on pull request #3403:
URL: https://github.com/apache/storm/pull/3403#issuecomment-875549464


   Addendum 1:
   
   I also cleaned up the Powershell code regarding CMDLet aliases (`echo` instead of `Write-Output`) and left-sided `$null`-comparison. These are not errors, but both are considered as bad practice for code that has to be maintained.
   
   The explanation for both cleanups can be found here:
   * [CMDLet aliases](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/RuleDocumentation/AvoidUsingCmdletAliases.md)
   * [left-sided `$null`-comparison](https://github.com/PowerShell/PSScriptAnalyzer/blob/master/RuleDocumentation/PossibleIncorrectComparisonWithNull.md)
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org