You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2018/10/15 17:51:42 UTC
[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression strategy for incr stats
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11685
Change subject: IMPALA-7708: Switch to faster deflater compression strategy for incr stats
......................................................................
IMPALA-7708: Switch to faster deflater compression strategy for incr stats
On a table with 3000 partitions and ~150 columns, we noticed that the
BEST_SPEED deflater strategy is ~8x faster with ~4% compression ratio
penalty. Given these results, this patch switches the default to
BEST_SPEED from BEST_COMPRESSION.
Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
---
M fe/src/main/java/org/apache/impala/util/CompressionUtil.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/11685/1
--
To view, visit http://gerrit.cloudera.org:8080/11685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Gerrit-Change-Number: 11685
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression level for incr stats
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11685 )
Change subject: IMPALA-7708: Switch to faster deflater compression level for incr stats
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11685/1/fe/src/main/java/org/apache/impala/util/CompressionUtil.java
File fe/src/main/java/org/apache/impala/util/CompressionUtil.java:
http://gerrit.cloudera.org:8080/#/c/11685/1/fe/src/main/java/org/apache/impala/util/CompressionUtil.java@43
PS1, Line 43: // Experiments on a wide partitioned table with incremental stats showed that the
> Update?
Done
--
To view, visit http://gerrit.cloudera.org:8080/11685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Gerrit-Change-Number: 11685
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 20:16:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression level for incr stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11685 )
Change subject: IMPALA-7708: Switch to faster deflater compression level for incr stats
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Gerrit-Change-Number: 11685
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 01:13:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression level for incr stats
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11685
to look at the new patch set (#2).
Change subject: IMPALA-7708: Switch to faster deflater compression level for incr stats
......................................................................
IMPALA-7708: Switch to faster deflater compression level for incr stats
On a table with 3000 partitions and ~150 columns, we noticed that the
BEST_SPEED deflater strategy is ~8x faster with ~4% compression ratio
penalty. Given these results, this patch switches the default to
BEST_SPEED from BEST_COMPRESSION.
Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
---
M fe/src/main/java/org/apache/impala/util/CompressionUtil.java
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/85/11685/2
--
To view, visit http://gerrit.cloudera.org:8080/11685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Gerrit-Change-Number: 11685
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression level for incr stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11685 )
Change subject: IMPALA-7708: Switch to faster deflater compression level for incr stats
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3315/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Gerrit-Change-Number: 11685
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 21:02:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression level for incr stats
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11685 )
Change subject: IMPALA-7708: Switch to faster deflater compression level for incr stats
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Gerrit-Change-Number: 11685
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 20:17:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression strategy for incr stats
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11685 )
Change subject: IMPALA-7708: Switch to faster deflater compression strategy for incr stats
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11685/1/fe/src/main/java/org/apache/impala/util/CompressionUtil.java
File fe/src/main/java/org/apache/impala/util/CompressionUtil.java:
http://gerrit.cloudera.org:8080/#/c/11685/1/fe/src/main/java/org/apache/impala/util/CompressionUtil.java@43
PS1, Line 43: // TODO: Benchmark other compression levels.
Update?
--
To view, visit http://gerrit.cloudera.org:8080/11685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Gerrit-Change-Number: 11685
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 17:54:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression level for incr stats
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11685 )
Change subject: IMPALA-7708: Switch to faster deflater compression level for incr stats
......................................................................
IMPALA-7708: Switch to faster deflater compression level for incr stats
On a table with 3000 partitions and ~150 columns, we noticed that the
BEST_SPEED deflater strategy is ~8x faster with ~4% compression ratio
penalty. Given these results, this patch switches the default to
BEST_SPEED from BEST_COMPRESSION.
Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Reviewed-on: http://gerrit.cloudera.org:8080/11685
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/util/CompressionUtil.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Philip Zeyliger: Looks good to me, approved
Vuk Ercegovac: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Gerrit-Change-Number: 11685
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7708: Switch to faster deflater compression level for incr stats
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11685 )
Change subject: IMPALA-7708: Switch to faster deflater compression level for incr stats
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife688aca3aed0e1e8af26c8348b850175d84b4ad
Gerrit-Change-Number: 11685
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 20:24:17 +0000
Gerrit-HasComments: No