You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/03/14 15:44:42 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #6116: Fix migration of VM with volume on Ubuntu
Pearl1594 opened a new pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116
### Description
This PR attempts to fix: https://github.com/apache/cloudstack/issues/6114
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1073003080
<b>Trillian test result (tid-3673)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31731 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6116-t3673-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 300.68 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1072238085
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068884645
@weizhouapache thanks for pinging me.
I will double-check the file history to get some context and remember what changed over time and why.
Thanks for stepping up with this PR, @Pearl1594!
I believe that most of the work I've done on that PR was related to extracting a few validations added by @nvazquez in https://github.com/apache/cloudstack/commit/0fbf5006b87b6c5bc6188e3e1dd226a98c3bb453 and align with the workflow in case of `Local volume` +` attached data disks`. Might be good if @nvazquez can join us and double-check it as well.
I have some meetings and tasks to run. Get back as soon as I can to refresh my memory and re-debug this flow.
Regarding @Pearl1594`s comment in https://github.com/apache/cloudstack/pull/6116#issuecomment-1068867617
@Pearl1594 I believe that you are right indeed. There are some special cases to be handled, with regards to being NFS migration or a local storage migration, which led to the subsequent checks you've referenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068971514
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1072238436
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1072238436
@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068937963
@Pearl1594 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067909238
<b>Trillian Build Failed (tid-3614)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067905322
@blueorangutan test ubuntu20 kvm-ubuntu20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068936744
<b>Trillian Build Failed (tid-3635)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067012876
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068935363
@blueorangutan test ubuntu20 kvm-ubuntu20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#discussion_r826906148
##########
File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
##########
@@ -82,10 +82,13 @@
*/
@Override
protected StrategyPriority internalCanHandle(Map<VolumeInfo, DataStore> volumeMap, Host srcHost, Host destHost) {
- if (super.internalCanHandle(volumeMap, srcHost, destHost) != StrategyPriority.CANT_HANDLE
- || canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost) != StrategyPriority.CANT_HANDLE) {
+ if (super.internalCanHandle(volumeMap, srcHost, destHost) != StrategyPriority.CANT_HANDLE) {
return StrategyPriority.CANT_HANDLE;
}
+ if (super.internalCanHandle(volumeMap, srcHost, destHost) == StrategyPriority.CANT_HANDLE &&
Review comment:
@Pearl1594 this check may not be required, it returns true always.
```suggestion
else if (canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost) != StrategyPriority.CANT_HANDLE) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068883368
> I am not sure if it would be correct @weizhouapache (I may be wrong), but based on the 4.15.2 code , it looks like if the strategy returned by `canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost` is CANT_HANDLE, then there are some subsequent checks done before returning can't handle
>
> ```
> if (canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost) == StrategyPriority.CANT_HANDLE) {
> Set<VolumeInfo> volumeInfoSet = volumeMap.keySet();
>
> for (VolumeInfo volumeInfo : volumeInfoSet) {
> StoragePoolVO storagePoolVO = _storagePoolDao.findById(volumeInfo.getPoolId());
> if (storagePoolVO.getPoolType() != StoragePoolType.Filesystem && storagePoolVO.getPoolType() != StoragePoolType.NetworkFilesystem) {
> return StrategyPriority.CANT_HANDLE;
> }
> }
> }
> ```
@Pearl1594
OK, so the logic in this PR looks like same as what before #5410 , right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068976036
@Pearl1594 a Trillian-Jenkins test job (ubuntu20 mgmt + kvm-ubuntu20) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1070333700
Tests on ubuntu are fixed, started a new round of tests for centos to ensure no regressions are added - can be merged after that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068931677
> > > I am not sure if it would be correct @weizhouapache (I may be wrong), but based on the 4.15.2 code , it looks like if the strategy returned by `canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost` is CANT_HANDLE, then there are some subsequent checks done before returning can't handle
> > > ```
> > > if (canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost) == StrategyPriority.CANT_HANDLE) {
> > > Set<VolumeInfo> volumeInfoSet = volumeMap.keySet();
> > >
> > > for (VolumeInfo volumeInfo : volumeInfoSet) {
> > > StoragePoolVO storagePoolVO = _storagePoolDao.findById(volumeInfo.getPoolId());
> > > if (storagePoolVO.getPoolType() != StoragePoolType.Filesystem && storagePoolVO.getPoolType() != StoragePoolType.NetworkFilesystem) {
> > > return StrategyPriority.CANT_HANDLE;
> > > }
> > > }
> > > }
> > > ```
> >
> >
> > @Pearl1594 OK, so the logic in this PR looks like same as what before #5410 , right ?
>
> Yes @weizhouapache
@Pearl1594
OK, looks good to me. let's wait for the smoke test results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1072238085
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067060477
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067089474
@Pearl1594 @nvazquez @sureshanaparti
this sounds like a critical issue in 4.16 as well
(it seems this operation is not supported in centos7 with stock qemu)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067090362
@Pearl1594 can you re-target to 4.16 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068936121
@Pearl1594 a Trillian-Jenkins test job (ubuntu20 mgmt + kvm-ubuntu20) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1072873963
<b>Trillian test result (tid-3662)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46441 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6116-t3662-kvm-centos7.zip
Smoke tests completed. 86 look OK, 6 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_add_primary_storage_disabled_host | `Error` | 0.58 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.18 | test_primary_storage.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 581.46 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Failure` | 343.92 | test_vpc_redundant.py
test_reboot_router | `Failure` | 461.39 | test_network.py
test_01_secure_vm_migration | `Error` | 161.28 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 266.01 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 142.81 | test_vm_life_cycle.py
test_08_migrate_vm | `Error` | 44.96 | test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.53 | test_snapshots.py
test_02_list_snapshots_with_removed_data_store | `Error` | 9.53 | test_snapshots.py
test_hostha_kvm_host_degraded | `Error` | 698.20 | test_hostha_kvm.py
test_hostha_kvm_host_fencing | `Error` | 681.64 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067063524
@nvazquez a Trillian-Jenkins test job (ubuntu20 mgmt + kvm-ubuntu20) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1073419732
Merging based on approvals and test results on ubuntu and KVM (error not related to the PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067905884
@Pearl1594 a Trillian-Jenkins test job (ubuntu20 mgmt + kvm-ubuntu20) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1070332780
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068867617
I am not sure if it would be correct @weizhouapache (I may be wrong), but based on the 4.15.2 code , it looks like if the strategy returned by `canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost` is CANT_HANDLE, then there are some subsequent checks done before returning can't handle
```
if (canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost) == StrategyPriority.CANT_HANDLE) {
Set<VolumeInfo> volumeInfoSet = volumeMap.keySet();
for (VolumeInfo volumeInfo : volumeInfoSet) {
StoragePoolVO storagePoolVO = _storagePoolDao.findById(volumeInfo.getPoolId());
if (storagePoolVO.getPoolType() != StoragePoolType.Filesystem && storagePoolVO.getPoolType() != StoragePoolType.NetworkFilesystem) {
return StrategyPriority.CANT_HANDLE;
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067009063
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1067061528
@blueorangutan test ubuntu20 kvm-ubuntu20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068925361
> > I am not sure if it would be correct @weizhouapache (I may be wrong), but based on the 4.15.2 code , it looks like if the strategy returned by `canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost` is CANT_HANDLE, then there are some subsequent checks done before returning can't handle
> > ```
> > if (canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost) == StrategyPriority.CANT_HANDLE) {
> > Set<VolumeInfo> volumeInfoSet = volumeMap.keySet();
> >
> > for (VolumeInfo volumeInfo : volumeInfoSet) {
> > StoragePoolVO storagePoolVO = _storagePoolDao.findById(volumeInfo.getPoolId());
> > if (storagePoolVO.getPoolType() != StoragePoolType.Filesystem && storagePoolVO.getPoolType() != StoragePoolType.NetworkFilesystem) {
> > return StrategyPriority.CANT_HANDLE;
> > }
> > }
> > }
> > ```
>
> @Pearl1594 OK, so the logic in this PR looks like same as what before #5410 , right ?
Yes @weizhouapache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068975010
@blueorangutan test ubuntu20 kvm-ubuntu20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1070332545
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1072929820
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1069156464
@Pearl1594 @weizhouapache tested and it is working fine when migrating VMs with `KVM` + `Root on Local`.
In case tests are all good, I am LGTM in having this one merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1069566855
<b>Trillian test result (tid-3636)</b>
Environment: kvm-ubuntu20 (x2), Advanced Networking with Mgmt server u20
Total time taken: 32410 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6116-t3636-kvm-ubuntu20.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068936935
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1072929923
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6116: Fix migration of VM with volume on Ubuntu
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068856784
the issue seems to be caused by #5410
@GabrielBrascher could you please review this PR ?
@Pearl1594 I am wondering if this is better
```
if (canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost) == StrategyPriority.CANT_HANDLE) {
return StrategyPriority.CANT_HANDLE;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org