You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2016/10/22 08:58:03 UTC
[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle
g.kocunik@gmail.com has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4796
Change subject: KUDU-1691 - [python] Replaced group varint encoding with bitshuffle
......................................................................
KUDU-1691 - [python] Replaced group varint encoding with bitshuffle
GROUP_VARINT is an internally used encoding which was removed for the C++ api.
BIT_SHUFFLE encoding was enabled in the python api.
Change-Id: I198fb6c43c1fbfd236f07b100934b8d9036bf16e
---
M python/kudu/__init__.py
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/4796/1
--
To view, visit http://gerrit.cloudera.org:8080/4796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I198fb6c43c1fbfd236f07b100934b8d9036bf16e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: g.kocunik@gmail.com
[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle
Posted by "Jordan Birdsell (Code Review)" <ge...@cloudera.org>.
Jordan Birdsell has posted comments on this change.
Change subject: KUDU-1691 - [python] Replaced group varint encoding with bitshuffle
......................................................................
Patch Set 1:
(1 comment)
Thanks for the patch Greg! Can you also add dictionary encoding? Make sure to also include a test for this, take a look at test_schema.py:test_encoding.
http://gerrit.cloudera.org:8080/#/c/4796/1//COMMIT_MSG
Commit Message:
PS1, Line 9: is an internally used encoding which was removed for the C++ api.
I would say its no longer supported and as such being removed from the Python API.
--
To view, visit http://gerrit.cloudera.org:8080/4796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I198fb6c43c1fbfd236f07b100934b8d9036bf16e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: g.kocunik@gmail.com
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
g.kocunik@gmail.com has abandoned this change.
Change subject: KUDU-1691 - [python] Replaced group varint encoding with bitshuffle
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/4796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I198fb6c43c1fbfd236f07b100934b8d9036bf16e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: g.kocunik@gmail.com
Gerrit-Reviewer: Jordan Birdsell <jo...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins