You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sohan Jain <so...@fb.com> on 2011/07/28 23:17:55 UTC
Review Request: Add ColumnarSerDe to the list of native SerDes
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1215/
-----------------------------------------------------------
Review request for hive and Paul Yang.
Summary
-------
We store metadata about ColumnarSerDes in the metastore, so it should be considered a native SerDe. Then, column information can be retrieved from the metastore instead of from deserialization.
This addresses bug HIVE-2322.
https://issues.apache.org/jira/browse/HIVE-2322
Diffs
-----
trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1151219
Diff: https://reviews.apache.org/r/1215/diff
Testing
-------
describe formatted tmp_tbl_name;
now returns the column's comments instead of "from deserializer"
Thanks,
Sohan
Re: Review Request: Add ColumnarSerDe to the list of native SerDes
Posted by Sohan Jain <so...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1215/
-----------------------------------------------------------
(Updated 2011-08-03 20:47:48.616906)
Review request for hive and Paul Yang.
Changes
-------
Updated the query test results, which don't say "from deserializer" anymore.
Summary
-------
We store metadata about ColumnarSerDes in the metastore, so it should be considered a native SerDe. Then, column information can be retrieved from the metastore instead of from deserialization.
This addresses bug HIVE-2322.
https://issues.apache.org/jira/browse/HIVE-2322
Diffs (updated)
-----
trunk/ql/src/test/results/clientpositive/alter_merge_stats.q.out 1152020
trunk/ql/src/test/results/clientpositive/alter_partition_format_loc.q.out 1152020
trunk/ql/src/test/results/clientpositive/columnarserde_create_shortcut.q.out 1152020
trunk/ql/src/test/results/clientpositive/combine3.q.out 1152020
trunk/ql/src/test/results/clientpositive/create_1.q.out 1152020
trunk/ql/src/test/results/clientpositive/index_bitmap_rc.q.out 1152020
trunk/ql/src/test/results/clientpositive/index_compact_2.q.out 1152020
trunk/ql/src/test/results/clientpositive/index_compact_3.q.out 1152020
trunk/ql/src/test/results/clientpositive/index_creation.q.out 1152020
trunk/ql/src/test/results/clientpositive/rcfile_bigdata.q.out 1152020
trunk/ql/src/test/results/clientpositive/rcfile_columnar.q.out 1152020
trunk/ql/src/test/results/clientpositive/rcfile_default_format.q.out 1152020
trunk/ql/src/test/results/clientpositive/rcfile_merge4.q.out 1152020
trunk/ql/src/test/results/clientpositive/sample_islocalmode_hook.q.out 1152020
trunk/ql/src/test/results/clientpositive/smb_mapjoin_6.q.out 1152020
trunk/ql/src/test/results/clientpositive/smb_mapjoin_8.q.out 1152020
trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java 1152020
Diff: https://reviews.apache.org/r/1215/diff
Testing
-------
describe formatted tmp_tbl_name;
now returns the column's comments instead of "from deserializer"
Thanks,
Sohan