You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/05/14 02:21:02 UTC
Review Request: More cgroup killTask() logging.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11129/
-----------------------------------------------------------
Review request for mesos.
Description
-------
>From 99b43f144b078f49c046b2a4dad0010c2e60a981 Mon Sep 17 00:00:00 2001
From: Brenden Matthews <br...@airbnb.com>
Date: Fri, 10 May 2013 13:27:53 -0700
Subject: [PATCH 22/24] More cgroup killTask() logging.
Review: https://reviews.apache.org/r/11129
---
src/linux/cgroups.cpp | 2 ++
1 file changed, 2 insertions(+)
Diffs
-----
src/linux/cgroups.cpp cfdc3b2d9203920021fdd891265d3595baa670ff
Diff: https://reviews.apache.org/r/11129/diff/
Testing
-------
Used in production at airbnb.
Thanks,
Brenden Matthews
Re: Review Request: More cgroup killTask() logging.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11129/#review20724
-----------------------------------------------------------
src/linux/cgroups.cpp
<https://reviews.apache.org/r/11129/#comment42792>
We generally avoid logging of statements that happen too frequently and are not much value outside debugging.
How about converting this to VLOG(1) instead?
This way you can start the slave with GLOG_v=1 in the env and get this if you are debugging something. Note that mesos also enables dynamically turning up logging by hitting a http endpoint on the slave.
- Vinod Kone
On May 14, 2013, 5:57 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11129/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 5:57 p.m.)
>
>
> Review request for mesos.
>
>
> Description
> -------
>
> From 99b43f144b078f49c046b2a4dad0010c2e60a981 Mon Sep 17 00:00:00 2001
> From: Brenden Matthews <br...@airbnb.com>
> Date: Fri, 10 May 2013 13:27:53 -0700
> Subject: [PATCH 22/24] More cgroup killTask() logging.
>
> Review: https://reviews.apache.org/r/11129
> ---
> src/linux/cgroups.cpp | 2 ++
> 1 file changed, 2 insertions(+)
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp cfdc3b2d9203920021fdd891265d3595baa670ff
>
> Diff: https://reviews.apache.org/r/11129/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 11129: More cgroup killTask() logging.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11129/#review84915
-----------------------------------------------------------
src/linux/cgroups.cpp
<https://reviews.apache.org/r/11129/#comment136368>
This method doesn't exist anymore and the freezer has since then been refactored.
Closing for now.
- Niklas Nielsen
On June 11, 2013, 11:43 a.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11129/
> -----------------------------------------------------------
>
> (Updated June 11, 2013, 11:43 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> More cgroup killTask() logging.
>
> Review: https://reviews.apache.org/r/11129
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp 8d94fe63610c4c7a48f92d260fcd526b7a83942e
>
> Diff: https://reviews.apache.org/r/11129/diff/
>
>
> Testing
> -------
>
> Used in production at airbnb.
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request: More cgroup killTask() logging.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11129/
-----------------------------------------------------------
(Updated June 11, 2013, 6:43 p.m.)
Review request for mesos.
Changes
-------
Rebasing on master.
Description
-------
More cgroup killTask() logging.
Review: https://reviews.apache.org/r/11129
Diffs (updated)
-----
src/linux/cgroups.cpp 8d94fe63610c4c7a48f92d260fcd526b7a83942e
Diff: https://reviews.apache.org/r/11129/diff/
Testing
-------
Used in production at airbnb.
Thanks,
Brenden Matthews
Re: Review Request: More cgroup killTask() logging.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11129/
-----------------------------------------------------------
(Updated June 6, 2013, 2:13 a.m.)
Review request for mesos.
Changes
-------
Rebasing on master.
Description
-------
More cgroup killTask() logging.
Review: https://reviews.apache.org/r/11129
Diffs (updated)
-----
src/linux/cgroups.cpp 8d94fe63610c4c7a48f92d260fcd526b7a83942e
Diff: https://reviews.apache.org/r/11129/diff/
Testing
-------
Used in production at airbnb.
Thanks,
Brenden Matthews
Re: Review Request: More cgroup killTask() logging.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11129/
-----------------------------------------------------------
(Updated June 3, 2013, 5:56 p.m.)
Review request for mesos.
Description (updated)
-------
More cgroup killTask() logging.
Review: https://reviews.apache.org/r/11129
Diffs (updated)
-----
src/linux/cgroups.cpp 8d94fe63610c4c7a48f92d260fcd526b7a83942e
Diff: https://reviews.apache.org/r/11129/diff/
Testing
-------
Used in production at airbnb.
Thanks,
Brenden Matthews
Re: Review Request: More cgroup killTask() logging.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11129/
-----------------------------------------------------------
(Updated May 14, 2013, 5:57 p.m.)
Review request for mesos.
Description
-------
>From 99b43f144b078f49c046b2a4dad0010c2e60a981 Mon Sep 17 00:00:00 2001
From: Brenden Matthews <br...@airbnb.com>
Date: Fri, 10 May 2013 13:27:53 -0700
Subject: [PATCH 22/24] More cgroup killTask() logging.
Review: https://reviews.apache.org/r/11129
---
src/linux/cgroups.cpp | 2 ++
1 file changed, 2 insertions(+)
Diffs (updated)
-----
src/linux/cgroups.cpp cfdc3b2d9203920021fdd891265d3595baa670ff
Diff: https://reviews.apache.org/r/11129/diff/
Testing
-------
Used in production at airbnb.
Thanks,
Brenden Matthews