You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/08/10 08:04:51 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/668
CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpath
-Adding "cls.hypervisor = cls.testClient.getHypervisorInfo()"
-Fixed pep8 issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pritisarap12/cloudstack CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/668.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #668
----
commit 23ac5588fb354b9ba36c9e0096287c700a85775f
Author: Priti Sarap <pr...@clogeny.com>
Date: 2015-08-10T06:00:55Z
CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha
-Adding "cls.hypervisor = cls.testClient.getHypervisorInfo()"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...
Posted by pritisarap12 <gi...@git.apache.org>.
Github user pritisarap12 commented on the pull request:
https://github.com/apache/cloudstack/pull/668#issuecomment-130566681
Updated testpath to get single commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/668
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/668#issuecomment-129368593
@pritisarap12 Please remove the merge commit and force push again. See PR #656 on how to do this. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...
Posted by Sanjeev N <sa...@apache.org>.
LGTM!!
On Mon, Aug 10, 2015 at 11:34 AM, pritisarap12 <gi...@git.apache.org> wrote:
> GitHub user pritisarap12 opened a pull request:
>
> https://github.com/apache/cloudstack/pull/668
>
>
> CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpath
>
> -Adding "cls.hypervisor = cls.testClient.getHypervisorInfo()"
> -Fixed pep8 issues
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/pritisarap12/cloudstack
> CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/cloudstack/pull/668.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #668
>
> ----
> commit 23ac5588fb354b9ba36c9e0096287c700a85775f
> Author: Priti Sarap <pr...@clogeny.com>
> Date: 2015-08-10T06:00:55Z
>
>
> CLOUDSTACK-8693-Adding-missing-code-in-testpath_same_vm_name.py_testpatha
> -Adding "cls.hypervisor = cls.testClient.getHypervisorInfo()"
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: CLOUDSTACK-8693-Adding-missing-code-in-te...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/668#issuecomment-130598324
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---