You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/11/16 19:08:40 UTC

[GitHub] eiri opened a new pull request #1744: Fix total_rows value for queries on `_design_docs` handler

eiri opened a new pull request #1744: Fix total_rows value for queries on `_design_docs` handler
URL: https://github.com/apache/couchdb/pull/1744
 
 
   ## Overview
   
   We've added a new URL end-point [`/{db}/_design_docs`](http://docs.couchdb.org/en/2.2.0/api/database/bulk-api.html#db-design-docs) reusing existing function for `_all_docs`. As a result the response for the new handler returns `total_rows` meta set to a total number of docs in a database, not just design docs as indicated in the documentation.
   
   This fix adds a custom enumerator for calculating number of ddocs and a new fabric wiring to access it.
   
   ## Testing recommendations
   
   **The tests are coming. I wanted to get this out to get the ball rolling in case the implementation will require a change**
   
   ## Related Issues or Pull Requests
   
   Closes #1603 
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [ ] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services