You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Chetan Mehrotra (JIRA)" <ji...@apache.org> on 2017/05/03 05:00:10 UTC

[jira] [Commented] (OAK-5412) Use GCMonitor for revision gc task run in DocumentNodeStore

    [ https://issues.apache.org/jira/browse/OAK-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994279#comment-15994279 ] 

Chetan Mehrotra commented on OAK-5412:
--------------------------------------

Looks good. 

# May be break the commit in 2 where 
## Refactoring related to use of Closer and 
## Changes required for GCMonitor support
# From use in Segment it appears that LoggingGCMonitor is not enabled as a service by default and needs to be explicitly used/configured. So may be we need to use DelegatingGCMonitor which used LoggingGCMonitor and GCMonitorTracker (/cc [~mduerig] )

> Use GCMonitor for revision gc task run in DocumentNodeStore
> -----------------------------------------------------------
>
>                 Key: OAK-5412
>                 URL: https://issues.apache.org/jira/browse/OAK-5412
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, documentmk
>            Reporter: Chetan Mehrotra
>            Assignee: Marcel Reutegger
>             Fix For: 1.8
>
>         Attachments: OAK-5412.patch
>
>
> DocumentNodeStore should use {{GCMonitor}} to inform interested parties about GC task progress (similar to how its used in SegmentNodeStore)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)