[jira] Commented: (OFBIZ-1689) CASifying OFBiz

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628016#action_12628016 ] 

Jacques Le Roux commented on OFBIZ-1689:
----------------------------------------

Shi,

There is, at least, one thing not clear in your last patch. You said that your ldap component works without the ldap.jar library but I see a reference to it in the patch. Are you sure it works without it (ok I can't see in zip, but...) ?

Else it looks good apart 
. Please don't put a reference to generated ofbiz-ldap.jar. And actually any Jars in patch : I will take them from your zip file and will put version in names as we do in OFBiz
. Add menu-name="secondary" in ofbiz-component.xml section webapp to place the button at bottom (though you put app-bar-display="false"). No base-permission needed ?
. Some tabs I easily replaced by 4 spaces in patch
. "ldap://127.0.0.1:389" in code. Should we not make a properties for that  (using localhost and separating server and port) ? 
. Same for "https://localhost:8443/cas" and what is https://cms.chinare.org.cn:8444/cas ?
. Also I would prefer 
   LDAPUiLabelsxml UTF8 file in place of LDAPUiLabels.properties and LDAPUiLabels_zh.properties
   FastMap in place of Hashtable

I'm ready to commit it, when you will have fixed the points above (please take them more as didactical)
I will commit in CTT mode (commit then test) as I have no need and time to test all the component now. 
So please be ready for questions when it will be really tested/used by other users...

Thanks for your work !

> CASifying OFBiz
> ---------------
>
>                 Key: OFBIZ-1689
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1689
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: ALL COMPONENTS
>    Affects Versions: Release Branch 4.0
>            Reporter: Shi Yusen
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>             Fix For: Release Branch 4.0
>
>         Attachments: ldap.zip, ofbiz-trunk688743-ldap-patch-20080901.txt, ofbiz4.0-ldap-patch-20080828.txt
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> I'll start my work on CASifying OFBiz, the method will be similar to this one:
> http://www.ja-sig.org/wiki/display/CASC/CASifying+OpenCms
> Please keep this issue open, I'll post my code to this issue when it's done.
> I'm eager to hear your suggestions on this topic.
> TIA
> Shi Yusen/Beijing Langhua Ltd.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.