You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/02/21 21:21:00 UTC

[jira] [Work logged] (HADOOP-18138) UserGroupInformation shouldn't log exception

     [ https://issues.apache.org/jira/browse/HADOOP-18138?focusedWorklogId=730541&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-730541 ]

ASF GitHub Bot logged work on HADOOP-18138:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Feb/22 21:20
            Start Date: 21/Feb/22 21:20
    Worklog Time Spent: 10m 
      Work Description: sunchao opened a new pull request #4007:
URL: https://github.com/apache/hadoop/pull/4007


   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 'HADOOP-17799. Your PR title ...'.
   -->
   
   ### Description of PR
   
   In UserGroupInformation.doAs, we currently create a new Exception and log it in LOG.debug. This doesn't look necessary:
   
   ```
         if (LOG.isDebugEnabled()) {
           LOG.debug("PrivilegedAction [as: {}][action: {}]", this, action,
               new Exception());
         }
   ```
   
   ### How was this patch tested?
   
   Existing tests.
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 730541)
    Remaining Estimate: 0h
            Time Spent: 10m

> UserGroupInformation shouldn't log exception 
> ---------------------------------------------
>
>                 Key: HADOOP-18138
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18138
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Chao Sun
>            Assignee: Chao Sun
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In {{UserGroupInformation.doAs}}, we currently create a new {{Exception}} and log it in {{LOG.debug}}. This doesn't look necessary:
> {code}
>       if (LOG.isDebugEnabled()) {
>         LOG.debug("PrivilegedAction [as: {}][action: {}]", this, action,
>             new Exception());
>       }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org