You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@issues.apache.org on 2010/04/23 19:47:01 UTC
[Bug 6422] New: $VERSION = 'bogus'; is bad.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Summary: $VERSION = 'bogus'; is bad.
Product: Spamassassin
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Building & Packaging
AssignedTo: dev@spamassassin.apache.org
ReportedBy: ifettich@netsoft.ro
On a Fedora 12 WS, mostly up to date, CPANPLUS ceased to work when asked to do
the regular updates:
# perl -MCPANPLUS -e shell;
CPANPLUS::Shell::Default -- CPAN exploration and module installation (v0.9003)
[ERROR] Invalid version format (non-numeric data) at
/usr/lib/perl5/5.10.0/Module/Load/Conditional.pm line 302.
The error is actually caused by the way version number is handled within some
modules (Mail::SpamAssassin::Dns, Mail::SpamAssassin::Reporter,
Mail::SpamAssassin::Plugin, Mail::SpamAssassin::Conf for sure, maybe others
too), where the (public) version number is set as
$VERSION = 'bogus'; # avoid CPAN.pm picking up razor version
Looks like with newer Perls this kind of version number will generate trouble,
so I think that this should be indeed fixed and set in a way that obeys
CPAN[PLUS] habits or recommendations.
I'm not sure what the recommended way is, so I'm not sure what an apppropiate
patch would be.
Thanks.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Whiteboard|needs 2 +1 votes to commit |needs 1 +1 votes to commit
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Whiteboard| |needs 2 +1 votes to commit
--- Comment #10 from Kevin A. McGrail <km...@pccc.com> ---
(In reply to Mark Martinec from comment #8)
> The file Mail/SpamAssassin/Plugin.pm still contains $VERSION='bogus',
> although I suppose this can be fixed later with 3.4.1.
I'd prefer to fix it now for the packaging tomorrow. We are on RTC so +1 to
commit this:
Index: lib/Mail/SpamAssassin/Plugin.pm
===================================================================
--- lib/Mail/SpamAssassin/Plugin.pm (revision 1564626)
+++ lib/Mail/SpamAssassin/Plugin.pm (working copy)
@@ -107,7 +107,8 @@
};
@ISA = qw();
-$VERSION = 'bogus';
+#Removed $VERSION per BUG 6422
+#$VERSION = 'bogus';
###########################################################################
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #14 from Kevin A. McGrail <km...@pccc.com> ---
Considering resolved.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Whiteboard|needs 1 +1 votes to commit |
--- Comment #13 from Kevin A. McGrail <km...@pccc.com> ---
svn commit -m'missed one bogus version per bug 6422'
Sending lib/Mail/SpamAssassin/Plugin.pm
Transmitting file data .
Committed revision 1564982.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] [review] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
--- Comment #5 from Mark Martinec <Ma...@ijs.si> ---
(In reply to comment #1)
> Created attachment 4996 [details]
> Patch to change $VERSION in a few pm's and sa-update
> I propose removing all of the VERSION lines as the words "bogus" appear to
> exist to "fix" a cpan issue that now breaks things.
+1, go ahead with this, Kevin.
That "bogus" hack looks terrible indeed, fixing a bug elsewhere by
introducing invalid code here.
> In the end, when we get 3.4.0 rc1 up on CPAN, it should be tested
> with perl > 5.14.0 to make sure that it works.
It works under perl 5.14.2, 5.16.2,
and 5.17.9 (this last one is running here in production).
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] [review] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
dolmen <do...@cpan.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dolmen@cpan.org
--- Comment #2 from dolmen <do...@cpan.org> 2011-12-24 09:25:48 UTC ---
This also breaks App::cpanoutdated.
I've reported the problem on the App::cpanoutdated side.
https://rt.cpan.org/Ticket/Display.html?id=73465
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6422] [review] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmcgrail@pccc.com
Summary|$VERSION = 'bogus'; is bad. |[review] $VERSION =
| |'bogus'; is bad.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6422] [review] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |a2340300@jnxjn.com
--- Comment #3 from Kevin A. McGrail <km...@pccc.com> 2012-01-17 19:32:14 UTC ---
*** Bug 6570 has been marked as a duplicate of this bug. ***
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Whiteboard|Pending rc3 being sent up |
|to CPAN to see what |
|happens. |
--- Comment #7 from Kevin A. McGrail <km...@pccc.com> ---
FYI, Cpan has rc6 uploaded as a DEVELOPER release
http://search.cpan.org/~kmcgrail/Mail-SpamAssassin-3.4.0-rc6-TRIAL/
Please test and let us know if this is resolved.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[review] $VERSION = |$VERSION = 'bogus'; is bad.
|'bogus'; is bad. |
Whiteboard| |Pending rc3 being sent up
| |to CPAN to see what
| |happens.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] [review] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.4.0
--- Comment #4 from Kevin A. McGrail <km...@pccc.com> 2012-01-17 20:12:04 UTC ---
In the end, when we get 3.4.0 rc1 up on CPAN, it should be tested with perl
5.14.0 to make sure that it works.
3.3.2 seems to be failing on CPAN a little:
http://www.cpantesters.org/distro/M/Mail-SpamAssassin.html#Mail-SpamAssassin-3.3.2
One thing I noticed on my test box was similar to this error:
http://www.cpantesters.org/cpan/report/ccf897b2-a59f-11e0-96f9-a254a96f2e35
t/cidrs.t (Wstat: 0 Tests: 51 Failed: 4)
Failed tests: 15-17, 41
t/recreate.t (Wstat: 0 Tests: 9 Failed: 1)
Failed test: 9
with lots of Jul 3 14:04:26.276 [12501] warn: netset: cannot include
0:0:0:0:0:0:0:1/128 as it has already been included
This appears to be related to bug 6681 and NetAddr::IP.
Will reopen that bug.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Benny Pedersen <me...@junc.eu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |me@junc.eu
--- Comment #9 from Benny Pedersen <me...@junc.eu> ---
why wait ?
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
--- Comment #11 from AXB <ax...@gmail.com> ---
+1 and push it out!
We have new challenges in the pipeline .-)
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] [review] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
--- Comment #6 from Kevin A. McGrail <km...@pccc.com> ---
(In reply to Mark Martinec from comment #5)
> (In reply to comment #1)
> > Created attachment 4996 [details]
> > Patch to change $VERSION in a few pm's and sa-update
> > I propose removing all of the VERSION lines as the words "bogus" appear to
> > exist to "fix" a cpan issue that now breaks things.
>
> +1, go ahead with this, Kevin.
I'm debating if we need to have numerical VERSION's defined on these pm's but
in the meantime, I've removed them from:
M lib/Mail/SpamAssassin/Dns.pm
M lib/Mail/SpamAssassin/Reporter.pm
M lib/Mail/SpamAssassin/Conf.pm
M lib/Mail/SpamAssassin/PluginHandler.pm
svn commit -m 'Removed VERSION string from several pm files per bug 6422'
Sending lib/Mail/SpamAssassin/Conf.pm
Sending lib/Mail/SpamAssassin/Dns.pm
Sending lib/Mail/SpamAssassin/PluginHandler.pm
Sending lib/Mail/SpamAssassin/Reporter.pm
Transmitting file data ....
Committed revision 1495486.
Next step will be uploading rc3 to cpan and seeing if it complains.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
--- Comment #8 from Mark Martinec <Ma...@ijs.si> ---
> FYI, Cpan has rc6 uploaded as a DEVELOPER release
> http://search.cpan.org/~kmcgrail/Mail-SpamAssassin-3.4.0-rc6-TRIAL/
Nice, thanks. Looks good.
> Please test and let us know if this is resolved.
The file Mail/SpamAssassin/Plugin.pm still contains $VERSION='bogus',
although I suppose this can be fixed later with 3.4.1.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
--- Comment #1 from Kevin A. McGrail <km...@pccc.com> 2011-10-29 04:01:31 UTC ---
Created attachment 4996
--> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4996
Patch to change $VERSION in a few pm's and sa-update
lib/Mail/SpamAssassin/Dns.pm:
$VERSION = 'bogus'; # avoid CPAN.pm picking up razor ver
lib/Mail/SpamAssassin/Plugin.pm:
$VERSION = 'bogus';
lib/Mail/SpamAssassin/Reporter.pm:
$VERSION = 'bogus'; # avoid CPAN.pm picking up razor ver
lib/Mail/SpamAssassin/Conf.pm:
$VERSION = 'bogus'; # avoid CPAN.pm picking up version strings later
lib/Mail/SpamAssassin/PluginHandler.pm:
$VERSION = 'bogus'; # avoid CPAN.pm picking up version strings later
I propose removing all of the VERSION lines as the words "bogus" appear to
exist to "fix" a cpan issue that now breaks things.
Additionaly, I've changed sa-update.raw's VERSION to a call to
&Mail::SpamAssassin::version() as shown in the attached patch.
We can then see what happens when we upload 3.4.0 rc1 to CPAN.
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
[Bug 6422] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
--- Comment #12 from Mark Martinec <Ma...@ijs.si> ---
+1 sure, go ahead
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 6422] [review] $VERSION = 'bogus'; is bad.
Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6422
Kevin A. McGrail <km...@pccc.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |blocker
--
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.