[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #4742: Adding bootstrap mode for Pinot-hadoop job to output segments into relative directories.

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #4742: Adding bootstrap mode for Pinot-hadoop job to output segments into relative directories.
URL: https://github.com/apache/incubator-pinot/pull/4742#discussion_r338707150
 
 

 ##########
 File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/JobConfigConstants.java
 ##########
 @@ -59,4 +59,5 @@
   // This setting should be used if you will generate less # of segments after
   // push. In preprocessing, this is likely because we resize segments.
   public static final String DELETE_EXTRA_SEGMENTS = "delete.extra.segments";
+  public static final String BOOTSTRAP_JOB = "job.bootstrap";
 
 Review comment:
   Recommend using something more specific such as "use.relative.path". I don't see a clear connection between bootstrap and using relative path.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org