You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/01 12:30:19 UTC
[GitHub] [airflow] CelastrinaLadon opened a new pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
CelastrinaLadon opened a new pull request #15134:
URL: https://github.com/apache/airflow/pull/15134
my code just add loggin.info cause the old is already call get_mod_time from hook but just not showing to log
and I really want it's to show π
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#issuecomment-811933562
[The Workflow run](https://github.com/apache/airflow/actions/runs/708735755) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] CelastrinaLadon commented on a change in pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
CelastrinaLadon commented on a change in pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#discussion_r608296756
##########
File path: airflow/sensors/filesystem.py
##########
@@ -57,6 +58,9 @@ def poke(self, context):
for path in glob(full_path):
if os.path.isfile(path):
+ mod_time = os.path.getmtime(path)
+ mod_time = datetime.datetime.fromtimestamp(mod_time).strftime('%Y%m%d%H%M%S')
Review comment:
but in SFTP and FTP i using get_mod_time function it's return string format date like this `.strftime('%Y%m%d%H%M%S')`
if you want to readable we should be change shall we change get_mod_time too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#discussion_r608701003
##########
File path: airflow/sensors/filesystem.py
##########
@@ -57,6 +58,9 @@ def poke(self, context):
for path in glob(full_path):
if os.path.isfile(path):
+ mod_time = os.path.getmtime(path)
+ mod_time = datetime.datetime.fromtimestamp(mod_time).strftime('%Y%m%d%H%M%S')
Review comment:
Right, I see what you mean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on a change in pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on a change in pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#discussion_r606019412
##########
File path: airflow/sensors/filesystem.py
##########
@@ -57,6 +58,9 @@ def poke(self, context):
for path in glob(full_path):
if os.path.isfile(path):
+ mod_time = os.path.getmtime(path)
+ mod_time = datetime.fromtimestamp(mod_time).strftime('%Y%m%d%H%M%S')
+ self.log.info(f'Found File {full_path} last modified: {mod_time}')
Review comment:
Since the logging takes place inside the loop, this should probably log `path`
```suggestion
self.log.info(f'Found File {path} last modified: {mod_time}')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] CelastrinaLadon commented on a change in pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
CelastrinaLadon commented on a change in pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#discussion_r608296756
##########
File path: airflow/sensors/filesystem.py
##########
@@ -57,6 +58,9 @@ def poke(self, context):
for path in glob(full_path):
if os.path.isfile(path):
+ mod_time = os.path.getmtime(path)
+ mod_time = datetime.datetime.fromtimestamp(mod_time).strftime('%Y%m%d%H%M%S')
Review comment:
but in SFTP and FTPI using get_mod_time function it's return string format date like this `.strftime('%Y%m%d%H%M%S')`
if you want to readable we should be change shall we change get_mod_time too ?
or we just parse datetime and then format to for readable again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#issuecomment-814959623
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] CelastrinaLadon commented on a change in pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
CelastrinaLadon commented on a change in pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#discussion_r608296756
##########
File path: airflow/sensors/filesystem.py
##########
@@ -57,6 +58,9 @@ def poke(self, context):
for path in glob(full_path):
if os.path.isfile(path):
+ mod_time = os.path.getmtime(path)
+ mod_time = datetime.datetime.fromtimestamp(mod_time).strftime('%Y%m%d%H%M%S')
Review comment:
but in SFTP and FTPI using get_mod_time function it's return string format date like this `.strftime('%Y%m%d%H%M%S')`
if you want to readable we should be change shall we change get_mod_time too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#issuecomment-812257634
Can you make the changes required by the failing static tests? https://github.com/apache/airflow/pull/15134/checks?check_run_id=2246371510#step:9:93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#discussion_r606449285
##########
File path: airflow/sensors/filesystem.py
##########
@@ -57,6 +58,9 @@ def poke(self, context):
for path in glob(full_path):
if os.path.isfile(path):
+ mod_time = os.path.getmtime(path)
+ mod_time = datetime.datetime.fromtimestamp(mod_time).strftime('%Y%m%d%H%M%S')
Review comment:
```suggestion
mod_time = datetime.datetime.fromtimestamp(mod_time)
```
otherwise, we will get `20210401160147` (which isn't that readable)
The default is anyways good enough:
```python
>>> str(datetime.datetime.fromtimestamp(os.path.getmtime("some_file.txt")))
'2021-04-01 16:01:47.227895'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #15134:
URL: https://github.com/apache/airflow/pull/15134#issuecomment-811873008
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15134: add loggin.info when poke in SFTP,FTP and Filesystem sensor to show last modified
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15134:
URL: https://github.com/apache/airflow/pull/15134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org