You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/03/10 16:52:28 UTC

[GitHub] zeppelin pull request #2121: [ZEPPELIN-2245] separate precode into JDBCInter...

GitHub user tinkoff-dwh opened a pull request:

    https://github.com/apache/zeppelin/pull/2121

    [ZEPPELIN-2245] separate precode into JDBCInterpreter

    ### What is this PR for?
    Separate precode by prefix
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2245
    
    ### How should this be tested?
    1. Set properties
     ```
    default.password 	1
    default.precode 	set search_path='test_path'
    default.url 	jdbc:postgresql://localhost:5432/
    default.user 	postgres
    mysql.driver 	com.mysql.jdbc.Driver
    mysql.password 	1
    mysql.precode 	set @v=12
    mysql.url 	jdbc:mysql://localhost:3306/
    mysql.user 	root 
    ```
    2. Run 
    `show search_path`
    3 Run
    ```
    %jdbc(mysql)
    select @v
    ```
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2245

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2121
    
----
commit f896ea8cb0651c64e09401e0b0187a98f6ca628e
Author: Tinkoff DWH <ti...@gmail.com>
Date:   2017-03-10T16:01:06Z

    [ZEPPELIN-2245] separate precode into JDBCInterpreter

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2121: [ZEPPELIN-2245] separate precode into JDBCInter...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2121


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2121: [ZEPPELIN-2245] separate precode into JDBCInterpreter

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2121
  
    link to #2078 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2121: [ZEPPELIN-2245] separate precode into JDBCInterpreter

Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2121
  
    @felixcheung 
    done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2121: [ZEPPELIN-2245] separate precode into JDBCInterpreter

Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2121
  
    CI green https://travis-ci.org/tinkoff-dwh/zeppelin/builds/210855494


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2121: [ZEPPELIN-2245] separate precode into JDBCInterpreter

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2121
  
    @Leemoonsoo it looks like Jenkins is timing out again while Travis is actually passing (though taking a long time)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2121: [ZEPPELIN-2245] separate precode into JDBCInterpreter

Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:

    https://github.com/apache/zeppelin/pull/2121
  
    @felixcheung 
    what kind of description, PR or changes from last commit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2121: [ZEPPELIN-2245] separate precode into JDBCInterpreter

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2121
  
    To elaborate, this is what the documentation says
    ```
    ### Usage `precode`
    <-- this is a new section
     +You can set `precode` for each data source. Code runs once while opening the connection.
    <--- good, there's a description
    
     +##### Properties
    <-- here we start a subsection
    
     +<table class="table-configuration">
     +  <tr>
     +    <th>Property Name</th>
     +    <th>Value</th>
     +  </tr>
     +  <tr>
     +    <td>default.driver</td>
     +    <td>org.postgresql.Driver</td>
    <-- there we have a table immediately...
    <-- what is default., mysql.? why do we need this properties/table?
     +  <tr>
     +    <td>mysql.url</td>
     +    <td>jdbc:mysql://localhost:3306/</td>
     +  <tr>
     +    <td>mysql.precode</td>
     +    <td>set @v=12</td>
     +  </tr>
    
     +</table>
     +
     +##### Usage
     +```sql
     +%jdbc(mysql)
     +select @v
    <-- can we say here we get in return v, which is set in the precode
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2121: [ZEPPELIN-2245] separate precode into JDBCInterpreter

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2121
  
    thanks, I see the changes, it would be good if you could add more descriptions on what they are doing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2121: [ZEPPELIN-2245] separate precode into JDBCInterpreter

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2121
  
    merging if no more comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---