[GitHub] [activemq-artemis-native] franz1981 commented on issue #6: Artemis 2562 Reduces context-switches on iocb pool

[GitBox <gi...@apache.org>]

franz1981 commented on issue #6: Artemis 2562 Reduces context-switches on iocb pool
URL: https://github.com/apache/activemq-artemis-native/pull/6#issuecomment-558323279
 
 
   You're right but the risk is that If the pooled iocb won't go into the pool
   we will free it, making the kernel to segsv on the first access...I would
   prefer a leak then a segmentation fault, but I agree that some warns
   should  be printed
   
   Il lun 25 nov 2019, 20:58 clebertsuconic <no...@github.com> ha
   scritto:
   
   > *@clebertsuconic* commented on this pull request.
   > ------------------------------
   >
   > In src/main/c/org_apache_activemq_artemis_nativo_jlibaio_LibaioContext.c
   > <https://github.com/apache/activemq-artemis-native/pull/6#discussion_r350391391>
   > :
   >
   > > @@ -502,7 +502,7 @@ static inline void iocb_destroy_bounded(struct io_control * theControl, int uppe
   >   * @param theControl
   >   */
   >  static inline void iocb_destroy(struct io_control * theControl) {
   > -    iocb_destroy_bounded(theControl, theControl->queueSize);
   >
   > it should really be the queueSize here for correctness... at this point
   > queueSize should be == available though, in which case you could assert.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/activemq-artemis-native/pull/6?email_source=notifications&email_token=ADEENMZWGU45WQHZREDLKUTQVQU5BA5CNFSM4JRNKCG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCM4ZL4Y#pullrequestreview-322541043>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ADEENM6YQ3M7BF323UHVC4TQVQU5BANCNFSM4JRNKCGQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services