You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/21 14:36:36 UTC
[GitHub] [skywalking-php] jmjoy opened a new pull request, #25: Update minimal supported PHP version to 7.2.
jmjoy opened a new pull request, #25:
URL: https://github.com/apache/skywalking-php/pull/25
Because our CI tests PHP version is greater than or equal to 7.2 (Many composer dependencies need PHP 7.2+).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] remicollet commented on pull request #25: Update minimal supported PHP version to 7.2.
Posted by GitBox <gi...@apache.org>.
remicollet commented on PR #25:
URL: https://github.com/apache/skywalking-php/pull/25#issuecomment-1329038422
This seems not fully done as package.xml (from pecl package) still say 7.1
```
<dependencies>
<required>
<php>
<min>7.1.0</min>
</php>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] wu-sheng merged pull request #25: Update minimal supported PHP version to 7.2.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #25:
URL: https://github.com/apache/skywalking-php/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] jmjoy commented on pull request #25: Update minimal supported PHP version to 7.2.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #25:
URL: https://github.com/apache/skywalking-php/pull/25#issuecomment-1329042123
> This seems not fully done as package.xml (from pecl package) still say 7.1
Thanks, I will fix it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-php] wu-sheng commented on a diff in pull request #25: Update minimal supported PHP version to 7.2.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on code in PR #25:
URL: https://github.com/apache/skywalking-php/pull/25#discussion_r1001896512
##########
docs/en/setup/service-agent/php-agent/README.md:
##########
@@ -1,24 +1,33 @@
# Setup PHP Agent
-1. Agent is available for PHP 7.0 - 8.x
+1. Agent is available for PHP 7.2 - 8.x
2. Build from source
3. Configure php.ini
## Requirements
+- GCC
+- Rustc
+- Cargo
+- Libclang
+- Make
+- Protoc
+
For Debian-base OS:
```shell script
sudo apt install gcc make cargo libclang protobuf-compiler
```
-## Install from pecl.net
+## Install
+
+### Install from pecl.net
```shell script
-sudo pecl install skywalking_agent
+pecl install skywalking_agent
```
-## Build & install from source
+### Or install from source
Review Comment:
```suggestion
### install from the source codes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org