You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by evthoriz <gi...@git.apache.org> on 2017/06/27 12:09:44 UTC
[GitHub] incubator-rocketmq pull request #128: bugix in batch scenario
GitHub user evthoriz opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/128
bugix in batch scenario
Bug in handle batch response. It will write response twice to client in batch scenario.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/evthoriz/incubator-rocketmq bugfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #128
----
commit 04923dc09f32914020ef99eac8c3116889d9ce61
Author: evthoriz <ev...@gmail.com>
Date: 2017-06-27T11:55:41Z
bugix in batch scenario
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: bugfix in batch scenario
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
[](https://:/builds/12149765)
Coverage increased (+0.04%) to 38.704% when pulling **04923dc09f32914020ef99eac8c3116889d9ce61 on evthoriz:bugfix** into **a9b66d5e5cb25405ac9a283aad678db32e75d511 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...
Posted by lindzh <gi...@git.apache.org>.
Github user lindzh commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
+1
Great! This is indeed buggy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
+1
Nice catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
@evthoriz Great catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: bugfix in batch scenario
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
[](https://:/builds/12149765)
Coverage increased (+0.04%) to 38.704% when pulling **04923dc09f32914020ef99eac8c3116889d9ce61 on evthoriz:bugfix** into **a9b66d5e5cb25405ac9a283aad678db32e75d511 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
@evthoriz please update the jira's discriptions so that the user knows this bug and determine whether they should upgrade
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: bugfix in batch scenario
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
@evthoriz thanks, It's a bug indeed, could you please attach a JIRA issue link here and polish the PR title with more details?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #128: [ROCKETMQ-234] bugfix - broker will wr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...
Posted by evthoriz <gi...@git.apache.org>.
Github user evthoriz commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
@zhouxinyu JIRA issue attached.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...
Posted by evthoriz <gi...@git.apache.org>.
Github user evthoriz commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
@Jaskey From the aspect of client, every batch request would cause printing 2 warning logs. But the further influence is it may damage the performance in high throughput scenario where batch interface would more likely be used, because it wasted netty's IO thread time doing meaningless encoding, decoding and printing logs things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #128: [ROCKETMQ-234] bugfix - broker will write res...
Posted by Jaskey <gi...@git.apache.org>.
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
+1.
This is is indeed buggy.
Would you please update the description that how the client behave for this problem so that we make our users clear about this.
IMO, this two results should be exactly the same and only logs can be observed but no factual influence
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---