You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "aleksraiden (via GitHub)" <gi...@apache.org> on 2024/11/04 09:51:35 UTC

[PR] use FetchContent_MakeAvailable instead of FetchContent_Populate [kvrocks]

aleksraiden opened a new pull request, #2647:
URL: https://github.com/apache/kvrocks/pull/2647

   This fix warning in build stage:
   
   > CMake Warning (dev) at /usr/local/share/cmake-3.30/Modules/FetchContent.cmake:1953 (message):
   > Calling FetchContent_Populate(fmt) is deprecated, call
   >  FetchContent_MakeAvailable(fmt) instead.  Policy CMP0169 can be set to OLD
   >  to allow FetchContent_Populate(fmt) to be called directly for now, but the
   >  ability to call it with declared details will be removed completely in a
   >  future version.
   >Call Stack (most recent call first):
   >  cmake/utils.cmake:31 (FetchContent_Populate)
   >  cmake/fmt.cmake:27 (FetchContent_MakeAvailableWithArgs)
   >  CMakeLists.txt:160 (include)
   >This warning is for project developers.  Use -Wno-dev to suppress it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: use FetchContent_MakeAvailable instead of FetchContent_Populate [kvrocks]

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on PR #2647:
URL: https://github.com/apache/kvrocks/pull/2647#issuecomment-2454502014

   There're differences between MakeAvailable and Populate, and we rely on these differences now.
   
   So it cannot be simply replaced. Need some investigation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: use FetchContent_MakeAvailable instead of FetchContent_Populate [kvrocks]

Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on PR #2647:
URL: https://github.com/apache/kvrocks/pull/2647#issuecomment-2454543421

   > There're differences between MakeAvailable and Populate, and we rely on these differences now.
   > 
   > So it cannot be simply replaced. Need some investigation.
   
   Yeah :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: use FetchContent_MakeAvailable instead of FetchContent_Populate [kvrocks]

Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden closed pull request #2647: chore: use FetchContent_MakeAvailable instead of FetchContent_Populate
URL: https://github.com/apache/kvrocks/pull/2647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org