You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ossie.apache.org by qu...@apache.org on 2026/09/15 00:24:38 UTC
(ossie) 01/01: security(dbt): Fix potential SSTI-to-RCE vector in dbt converter jinja rendering
This is an automated email from the ASF dual-hosted git repository.
QMalcolm pushed a commit to branch qmalcolm--security--dbt-converter-jinja-sandbox-fix
in repository https://gitbox.apache.org/repos/asf/ossie.git
commit cd5c3087a6db620d695ae7eafdc27729e7814607
Author: Quigley Malcolm <tq...@protonmail.com>
AuthorDate: Mon Sep 14 19:21:05 2026 -0500
security(dbt): Fix potential SSTI-to-RCE vector in dbt converter jinja
rendering
The `_render_filter_template` function in `filter_utils.py` was rendering jinja in a non-sandboxed environment. This meant that if the converter wasrun on a project containing untrusted input, a potential SSTI-to-RCE vector was available. By sandboxing the environment, we eliminate the issue.
---
converters/dbt/src/ossie_dbt/filter_utils.py | 17 ++++++++++++-----
converters/dbt/tests/test_msi_to_ossie.py | 5 +++++
2 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/converters/dbt/src/ossie_dbt/filter_utils.py b/converters/dbt/src/ossie_dbt/filter_utils.py
index 9875999d..2ef178a3 100644
--- a/converters/dbt/src/ossie_dbt/filter_utils.py
+++ b/converters/dbt/src/ossie_dbt/filter_utils.py
@@ -18,6 +18,7 @@
from typing import List, Optional, Sequence
import jinja2
+from jinja2.sandbox import SandboxedEnvironment
from metricflow_semantic_interfaces.protocols.where_filter import WhereFilterIntersection
@@ -115,12 +116,18 @@ def _render_filter_template(template: str) -> str:
and `{{ Metric('revenue') }}` are resolved to their column-name
equivalents using lightweight stubs. The output is a best-effort SQL
string suitable for embedding in an Ossie expression.
+
+ Sandboxing is necessary to prevent SSTI-to-RCE style exploits
"""
- return jinja2.Template(template, undefined=jinja2.StrictUndefined).render(
- Dimension=_DimensionStub,
- TimeDimension=_TimeDimensionStub,
- Entity=_EntityStub,
- Metric=_MetricStub,
+ return (
+ SandboxedEnvironment(undefined=jinja2.StrictUndefined)
+ .from_string(template)
+ .render(
+ Dimension=_DimensionStub,
+ TimeDimension=_TimeDimensionStub,
+ Entity=_EntityStub,
+ Metric=_MetricStub,
+ )
)
diff --git a/converters/dbt/tests/test_msi_to_ossie.py b/converters/dbt/tests/test_msi_to_ossie.py
index 98102628..aaeabd21 100644
--- a/converters/dbt/tests/test_msi_to_ossie.py
+++ b/converters/dbt/tests/test_msi_to_ossie.py
@@ -18,6 +18,7 @@
import json
from typing import List, Optional
+import jinja
import pytest
from syrupy.assertion import SnapshotAssertion
@@ -977,6 +978,10 @@ class TestFilterRendering:
def test_metric_reference(self) -> None:
assert _render_filter_template("{{ Metric('revenue') }} > 0") == "revenue > 0"
+
+ def test_ssti_gadget_payload_is_blocked(self) -> None: # noqa: D102
+ with pytest.raises(jinja2.exceptions.SecurityError):
+ _render_filter_template("{{ cycler.__init__.__globals__.os.popen('id').read() }}")
class TestMetricFilterFlattening: