You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Violeta Georgieva <vi...@apache.org> on 2019/12/10 10:03:59 UTC

Tag Tomcat 7

Hi,

I'm going of prepare Tomcat 7 for a release/vote tomorrow.
Please reply here if you need more time for additional fixes.

Thanks,
Violeta

Re: Tag Tomcat 7

Posted by Violeta Georgieva <vi...@apache.org>.
На ср, 11.12.2019 г. в 13:40 Konstantin Kolinko <kn...@gmail.com>
написа:
>
> вт, 10 дек. 2019 г. в 13:04, Violeta Georgieva <vi...@apache.org>:
> >
> > Hi,
> >
> > I'm going of prepare Tomcat 7 for a release/vote tomorrow.
> > Please reply here if you need more time for additional fixes.
>
> I think it is OK to go.

Thanks a lot
I'm gonna tag Tomcat 7

>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Tag Tomcat 7

Posted by Konstantin Kolinko <kn...@gmail.com>.
вт, 10 дек. 2019 г. в 13:04, Violeta Georgieva <vi...@apache.org>:
>
> Hi,
>
> I'm going of prepare Tomcat 7 for a release/vote tomorrow.
> Please reply here if you need more time for additional fixes.

I think it is OK to go.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Tag Tomcat 7

Posted by Violeta Georgieva <vi...@apache.org>.
На вт, 10.12.2019 г. в 17:10 Violeta Georgieva <vi...@apache.org>
написа:
>
>
>
> На вт, 10.12.2019 г. в 16:45 Konstantin Kolinko <kn...@gmail.com>
написа:
> >
> > > Re: c06674e09e9f3f43dc0e5c022dc8c311a4285cfd
> > > I'll fix it in a few minutes.
> >
> > Fixed.
> >
> > Another one noted:
> >
> > Re 6ef27808e499d5b84f9789e56dc0e846ef388005
> > > Partial fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63815
> >
> > There is a typo in daemon.sh
> >
> > -Dcatalina.base="\"$CATALINA_BASE"\" \
>
> Which is the line exactly?

ops it is daemon.sh

sorry for the noise


>
>
> I see two types only
>
> -Dcatalina.base="$CATALINA_BASE" \
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L363
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L372
>
> -Dcatalina.base="\"$CATALINA_BASE\"" \
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L392
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L400
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L460
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L470
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L523
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L610
>
>
> >
> > The right double quotes on other lines are quoted differently,
> > slash+dquote+dquote e.g:
> > -Dcatalina.home="\"$CATALINA_HOME\"" \
> >
> > It is hard for me to test whether there are visible consequences of
> > this typo. It affects 8.5 and 9.0 as well.
> >
> >
> >
> > вт, 10 дек. 2019 г. в 13:04, Violeta Georgieva <vi...@apache.org>:
> > >
> > > Hi,
> > >
> > > I'm going of prepare Tomcat 7 for a release/vote tomorrow.
> > > Please reply here if you need more time for additional fixes.
> > >
> > > Thanks,
> > > Violeta
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > For additional commands, e-mail: dev-help@tomcat.apache.org

>

Re: Tag Tomcat 7

Posted by Konstantin Kolinko <kn...@gmail.com>.
вт, 10 дек. 2019 г. в 20:34, Mark Thomas <ma...@apache.org>:
>
> On 10/12/2019 15:23, Mark Thomas wrote:
> > On 10/12/2019 15:20, Konstantin Kolinko wrote:
>
>
> <snip/>
>
> >>>> There is a typo in daemon.sh
> >>>>
> >>>> -Dcatalina.base="\"$CATALINA_BASE"\" \
> >
> > Good catch.
> >
> > I've just fixed it. Next task is to figure out how badly it breaks things.
>
> I think I might have got away with this (in terms of impact on the
> current releases).
>
> I did a quick test with the typo in place and a basic test of script
> works as does running in a directory with spaces.
>
> I'm sure there will be some edge cases that are still broken but my
> current plan is to pick up that fix in the next release.

I did a quick test using bash that comes with Git for Windows and
calling the following simple script that prints its arguments (instead
of calling jsvc):

[[[
#!/bin/sh
echo "Arguments:"
while [ $# -gt 0 ]
do
  echo "[$1]"
  shift
done
]]]

I was running with
JSVC=./args.sh
CATALINA_BASE="catalina base"
CATALINA_HOME="catalina home"
etc.

Both variants of quoting result in the same value being printed:
[-Dcatalina.base=catalina base]
[-Dcatalina.home=catalina home]

Thus that typo does not have any consequences.

Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Tag Tomcat 7

Posted by Mark Thomas <ma...@apache.org>.
On 10/12/2019 15:23, Mark Thomas wrote:
> On 10/12/2019 15:20, Konstantin Kolinko wrote:


<snip/>

>>>> There is a typo in daemon.sh
>>>>
>>>> -Dcatalina.base="\"$CATALINA_BASE"\" \
> 
> Good catch.
> 
> I've just fixed it. Next task is to figure out how badly it breaks things.

I think I might have got away with this (in terms of impact on the
current releases).

I did a quick test with the typo in place and a basic test of script
works as does running in a directory with spaces.

I'm sure there will be some edge cases that are still broken but my
current plan is to pick up that fix in the next release.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Tag Tomcat 7

Posted by Mark Thomas <ma...@apache.org>.
On 10/12/2019 15:20, Konstantin Kolinko wrote:
> вт, 10 дек. 2019 г. в 18:10, Violeta Georgieva <vi...@apache.org>:
>>
>>
>>
>> На вт, 10.12.2019 г. в 16:45 Konstantin Kolinko <kn...@gmail.com> написа:
>>>
>>>> Re: c06674e09e9f3f43dc0e5c022dc8c311a4285cfd
>>>> I'll fix it in a few minutes.
>>>
>>> Fixed.
>>>
>>> Another one noted:
>>>
>>> Re 6ef27808e499d5b84f9789e56dc0e846ef388005
>>>> Partial fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63815
>>>
>>> There is a typo in daemon.sh
>>>
>>> -Dcatalina.base="\"$CATALINA_BASE"\" \

Good catch.

I've just fixed it. Next task is to figure out how badly it breaks things.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Tag Tomcat 7

Posted by Konstantin Kolinko <kn...@gmail.com>.
вт, 10 дек. 2019 г. в 18:10, Violeta Georgieva <vi...@apache.org>:
>
>
>
> На вт, 10.12.2019 г. в 16:45 Konstantin Kolinko <kn...@gmail.com> написа:
> >
> > > Re: c06674e09e9f3f43dc0e5c022dc8c311a4285cfd
> > > I'll fix it in a few minutes.
> >
> > Fixed.
> >
> > Another one noted:
> >
> > Re 6ef27808e499d5b84f9789e56dc0e846ef388005
> > > Partial fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63815
> >
> > There is a typo in daemon.sh
> >
> > -Dcatalina.base="\"$CATALINA_BASE"\" \
>
> Which is the line exactly?
>
>
> I see two types only
>
> -Dcatalina.base="$CATALINA_BASE" \
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L363
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L372
>
> -Dcatalina.base="\"$CATALINA_BASE\"" \
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L392
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L400
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L460
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L470
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L523
> https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L610

It is daemon.sh line 231. It is in the code that implements "start"
command for daemon.
https://github.com/apache/tomcat/blob/7.0.x/bin/daemon.sh#L231

In 9.0.x as well:
https://github.com/apache/tomcat/blob/master/bin/daemon.sh#L231

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Tag Tomcat 7

Posted by Violeta Georgieva <vi...@apache.org>.
На вт, 10.12.2019 г. в 16:45 Konstantin Kolinko <kn...@gmail.com>
написа:
>
> > Re: c06674e09e9f3f43dc0e5c022dc8c311a4285cfd
> > I'll fix it in a few minutes.
>
> Fixed.
>
> Another one noted:
>
> Re 6ef27808e499d5b84f9789e56dc0e846ef388005
> > Partial fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63815
>
> There is a typo in daemon.sh
>
> -Dcatalina.base="\"$CATALINA_BASE"\" \

Which is the line exactly?


I see two types only

-Dcatalina.base="$CATALINA_BASE" \
https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L363
https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L372

-Dcatalina.base="\"$CATALINA_BASE\"" \
https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L392
https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L400
https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L460
https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L470
https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L523
https://github.com/apache/tomcat/blob/7.0.x/bin/catalina.sh#L610


>
> The right double quotes on other lines are quoted differently,
> slash+dquote+dquote e.g:
> -Dcatalina.home="\"$CATALINA_HOME\"" \
>
> It is hard for me to test whether there are visible consequences of
> this typo. It affects 8.5 and 9.0 as well.
>
>
>
> вт, 10 дек. 2019 г. в 13:04, Violeta Georgieva <vi...@apache.org>:
> >
> > Hi,
> >
> > I'm going of prepare Tomcat 7 for a release/vote tomorrow.
> > Please reply here if you need more time for additional fixes.
> >
> > Thanks,
> > Violeta
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Tag Tomcat 7

Posted by Konstantin Kolinko <kn...@gmail.com>.
> Re: c06674e09e9f3f43dc0e5c022dc8c311a4285cfd
> I'll fix it in a few minutes.

Fixed.

Another one noted:

Re 6ef27808e499d5b84f9789e56dc0e846ef388005
> Partial fix for https://bz.apache.org/bugzilla/show_bug.cgi?id=63815

There is a typo in daemon.sh

-Dcatalina.base="\"$CATALINA_BASE"\" \

The right double quotes on other lines are quoted differently,
slash+dquote+dquote e.g:
-Dcatalina.home="\"$CATALINA_HOME\"" \

It is hard for me to test whether there are visible consequences of
this typo. It affects 8.5 and 9.0 as well.



вт, 10 дек. 2019 г. в 13:04, Violeta Georgieva <vi...@apache.org>:
>
> Hi,
>
> I'm going of prepare Tomcat 7 for a release/vote tomorrow.
> Please reply here if you need more time for additional fixes.
>
> Thanks,
> Violeta

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

Re: Tag Tomcat 7

Posted by Konstantin Kolinko <kn...@gmail.com>.
Re: c06674e09e9f3f43dc0e5c022dc8c311a4285cfd

It added a reference to a message
sm.getString("coyoteRequest.changeSessionId"));

but there is no such message in LocalStrings.properties

I'll fix it in a few minutes.


вт, 10 дек. 2019 г. в 13:04, Violeta Georgieva <vi...@apache.org>:
>
> Hi,
>
> I'm going of prepare Tomcat 7 for a release/vote tomorrow.
> Please reply here if you need more time for additional fixes.
>
> Thanks,
> Violeta

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org