You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/11 05:11:02 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #4656: tcp: fixed issues with unackseq calculation.

yamt commented on a change in pull request #4656:
URL: https://github.com/apache/incubator-nuttx/pull/4656#discussion_r725792722



##########
File path: net/tcp/tcp_appsend.c
##########
@@ -241,6 +239,7 @@ void tcp_appsend(FAR struct net_driver_s *dev, FAR struct tcp_conn_s *conn,
            */
 
           conn->tx_unacked += dev->d_sndlen;
+          conn->sndseq_max += dev->d_sndlen;

Review comment:
       i'm not sure about this.
   is (sndseq_max == sndseq) always true here?
   if so, can you consider to assert it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org