'patch ready' workflow

[Joe Witt <jo...@gmail.com>]

team,

The ASF INFRA folks have enabled our 'patch ready' workflow.  This
should make it easier for us to see that patches have been submitted
and so we can prioritize getting them evaluated and merged above other
work.  All you have to do is once you've made your patch and verified
that the build is good to go just attach the patch to the JIRA ticket
in question and select the 'Submit Patch' button.  That will change
the status of the ticket and we can then sort on those easily.

We will put together a contributor guide and document all this so it
isn't such a guessing game as well.

We're seeing some really great contribs coming in through various
forms be it ideas, defect fixes, new features.  Really awesome to see!

Thanks!

Joe

Re: 'patch ready' workflow

[Sean Busbey <bu...@cloudera.com>]

one side-effect of switching to 'patch ready' is that folks who are just in
the default 'jira-users' group can no longer assign themselves tickets by
clicking on "start progress."

instead, folks need to get added to the "contributor" role in the jira
admin page. Could someone add me to that group so I can assign myself
things I'm working on?

On Sun, May 3, 2015 at 4:07 PM, Sean Busbey <bu...@cloudera.com> wrote:

> Sure thing.
>
> ASF build infra maintains a jenkins job that monitors jira for new
> patch-available tickets. For projects that set up a pre-commit jenkins job,
> that build infra job will kick off a job that applies the patch and tests
> it according to whatever a particular project wants to test.
>
> Usually it's things like making sure compilation & unit tests work,
> checkstyle rules are followed, javadoc warnings don't get added, etc. Most
> projects just copy a pre-commit test script from some other project; many
> of the test scripts eventually trace back to the Hadoop project.
>
> The Hadoop project recently revamped their pre-commit tester so that it
> can expressly be extended and reused by other projects. I'm already trying
> to use those changes to un-fork precommit testing on the HBase project, so
> adding it here will be relatively easy for me. It'll also give me a great
> additional data point about how suitable for general use the current
> framework is.
>
> It's usually called the QA bot because at the end of running tests, it
> posts to the jira a comment under that name. The comment gives a +/- 1 with
> a detailed report of what was checked and, if needed, where there were
> problems.
>
> Different communities place different weight on the comments from the QA
> bot. Since it's not a PMC member it doesn't have a binding vote, so
> committers are always free to use a judgement call to ignore part of its
> feedback. For example, if there's a flakey test or if someone else is
> working to unbreak a failing test that got into hte main development branch.
>
> On Sat, May 2, 2015 at 7:22 PM, Joe Witt <jo...@gmail.com> wrote:
>
>> Sean,
>>
>> That sounds great to me but must admit I'm not sure we all know what
>> it really means just yet.  Can you elaborate a bit on how you see it
>> best working and what the QA bot will do?
>>
>> Thanks
>> joe
>>
>> On Sat, May 2, 2015 at 5:31 PM, Sean Busbey <bu...@cloudera.com> wrote:
>> > If you're ready to start using patch-available on the regular, I'll
>> stand
>> > up the QA bot this weekend.
>> >
>> > --
>> > Sean
>> > On May 2, 2015 3:14 PM, "Joe Witt" <jo...@gmail.com> wrote:
>> >
>> >> team,
>> >>
>> >> The ASF INFRA folks have enabled our 'patch ready' workflow.  This
>> >> should make it easier for us to see that patches have been submitted
>> >> and so we can prioritize getting them evaluated and merged above other
>> >> work.  All you have to do is once you've made your patch and verified
>> >> that the build is good to go just attach the patch to the JIRA ticket
>> >> in question and select the 'Submit Patch' button.  That will change
>> >> the status of the ticket and we can then sort on those easily.
>> >>
>> >> We will put together a contributor guide and document all this so it
>> >> isn't such a guessing game as well.
>> >>
>> >> We're seeing some really great contribs coming in through various
>> >> forms be it ideas, defect fixes, new features.  Really awesome to see!
>> >>
>> >> Thanks!
>> >>
>> >> Joe
>> >>
>>
>
>
>
> --
> Sean
>



-- 
Sean

Re: 'patch ready' workflow

[Sean Busbey <bu...@cloudera.com>]

Sure thing.

ASF build infra maintains a jenkins job that monitors jira for new
patch-available tickets. For projects that set up a pre-commit jenkins job,
that build infra job will kick off a job that applies the patch and tests
it according to whatever a particular project wants to test.

Usually it's things like making sure compilation & unit tests work,
checkstyle rules are followed, javadoc warnings don't get added, etc. Most
projects just copy a pre-commit test script from some other project; many
of the test scripts eventually trace back to the Hadoop project.

The Hadoop project recently revamped their pre-commit tester so that it can
expressly be extended and reused by other projects. I'm already trying to
use those changes to un-fork precommit testing on the HBase project, so
adding it here will be relatively easy for me. It'll also give me a great
additional data point about how suitable for general use the current
framework is.

It's usually called the QA bot because at the end of running tests, it
posts to the jira a comment under that name. The comment gives a +/- 1 with
a detailed report of what was checked and, if needed, where there were
problems.

Different communities place different weight on the comments from the QA
bot. Since it's not a PMC member it doesn't have a binding vote, so
committers are always free to use a judgement call to ignore part of its
feedback. For example, if there's a flakey test or if someone else is
working to unbreak a failing test that got into hte main development branch.

On Sat, May 2, 2015 at 7:22 PM, Joe Witt <jo...@gmail.com> wrote:

> Sean,
>
> That sounds great to me but must admit I'm not sure we all know what
> it really means just yet.  Can you elaborate a bit on how you see it
> best working and what the QA bot will do?
>
> Thanks
> joe
>
> On Sat, May 2, 2015 at 5:31 PM, Sean Busbey <bu...@cloudera.com> wrote:
> > If you're ready to start using patch-available on the regular, I'll stand
> > up the QA bot this weekend.
> >
> > --
> > Sean
> > On May 2, 2015 3:14 PM, "Joe Witt" <jo...@gmail.com> wrote:
> >
> >> team,
> >>
> >> The ASF INFRA folks have enabled our 'patch ready' workflow.  This
> >> should make it easier for us to see that patches have been submitted
> >> and so we can prioritize getting them evaluated and merged above other
> >> work.  All you have to do is once you've made your patch and verified
> >> that the build is good to go just attach the patch to the JIRA ticket
> >> in question and select the 'Submit Patch' button.  That will change
> >> the status of the ticket and we can then sort on those easily.
> >>
> >> We will put together a contributor guide and document all this so it
> >> isn't such a guessing game as well.
> >>
> >> We're seeing some really great contribs coming in through various
> >> forms be it ideas, defect fixes, new features.  Really awesome to see!
> >>
> >> Thanks!
> >>
> >> Joe
> >>
>



-- 
Sean

Re: 'patch ready' workflow

[Joe Witt <jo...@gmail.com>]

Sean,

That sounds great to me but must admit I'm not sure we all know what
it really means just yet.  Can you elaborate a bit on how you see it
best working and what the QA bot will do?

Thanks
joe

On Sat, May 2, 2015 at 5:31 PM, Sean Busbey <bu...@cloudera.com> wrote:
> If you're ready to start using patch-available on the regular, I'll stand
> up the QA bot this weekend.
>
> --
> Sean
> On May 2, 2015 3:14 PM, "Joe Witt" <jo...@gmail.com> wrote:
>
>> team,
>>
>> The ASF INFRA folks have enabled our 'patch ready' workflow.  This
>> should make it easier for us to see that patches have been submitted
>> and so we can prioritize getting them evaluated and merged above other
>> work.  All you have to do is once you've made your patch and verified
>> that the build is good to go just attach the patch to the JIRA ticket
>> in question and select the 'Submit Patch' button.  That will change
>> the status of the ticket and we can then sort on those easily.
>>
>> We will put together a contributor guide and document all this so it
>> isn't such a guessing game as well.
>>
>> We're seeing some really great contribs coming in through various
>> forms be it ideas, defect fixes, new features.  Really awesome to see!
>>
>> Thanks!
>>
>> Joe
>>

Re: 'patch ready' workflow

[Sean Busbey <bu...@cloudera.com>]

If you're ready to start using patch-available on the regular, I'll stand
up the QA bot this weekend.

-- 
Sean
On May 2, 2015 3:14 PM, "Joe Witt" <jo...@gmail.com> wrote:

> team,
>
> The ASF INFRA folks have enabled our 'patch ready' workflow.  This
> should make it easier for us to see that patches have been submitted
> and so we can prioritize getting them evaluated and merged above other
> work.  All you have to do is once you've made your patch and verified
> that the build is good to go just attach the patch to the JIRA ticket
> in question and select the 'Submit Patch' button.  That will change
> the status of the ticket and we can then sort on those easily.
>
> We will put together a contributor guide and document all this so it
> isn't such a guessing game as well.
>
> We're seeing some really great contribs coming in through various
> forms be it ideas, defect fixes, new features.  Really awesome to see!
>
> Thanks!
>
> Joe
>