You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/03 15:21:15 UTC
[GitHub] [airflow] ryw opened a new pull request #7351: [AIRFLOW-XXXX] Add
scheduler in production section to best practices doc
ryw opened a new pull request #7351: [AIRFLOW-XXXX] Add scheduler in production section to best practices doc
URL: https://github.com/apache/airflow/pull/7351
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7351: [AIRFLOW-XXXX] Add
scheduler in production section to best practices doc
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7351: [AIRFLOW-XXXX] Add scheduler in production section to best practices doc
URL: https://github.com/apache/airflow/pull/7351#issuecomment-581800935
Thanks @ryw !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7351:
[AIRFLOW-XXXX] Add scheduler in production section to best practices doc
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7351: [AIRFLOW-XXXX] Add scheduler in production section to best practices doc
URL: https://github.com/apache/airflow/pull/7351#discussion_r374380633
##########
File path: docs/best-practices.rst
##########
@@ -315,3 +315,16 @@ Some configurations such as Airflow Backend connection URI can be derived from b
.. code::
sql_alchemy_conn_cmd = bash_command_to_run
+
+
+Scheduler Uptime
+-----------------
+
+Airflow users have for a long time been affected by a
+`core Airflow bug <https://issues.apache.org/jira/browse/AIRFLOW-401>`_
+that causes the scheduler to hang without a trace.
+
+Until fully resolved, you can mitigate a few ways:
+
+* Set a reasonable run_duration setting in your `airflow.cfg`. `See example <https://github.com/astronomer/airflow-chart/blob/63bc503c67e2cd599df0b6f831d470d09bad7ee7/templates/configmap.yaml#L44>`_.
+* Add an `exec` style health check to your helm charts on the scheduler deployment to fail if the scheduler has not heartbeat in a while. `See example <https://github.com/astronomer/helm.astronomer.io/pull/200/files>`_.
Review comment:
```suggestion
* Add an ``exec`` style health check to your helm charts on the scheduler deployment to fail if the scheduler has not heartbeat in a while. `See example <https://github.com/astronomer/helm.astronomer.io/pull/200/files>`_.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7351: [AIRFLOW-XXXX] Add
scheduler in production section to best practices doc
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7351: [AIRFLOW-XXXX] Add scheduler in production section to best practices doc
URL: https://github.com/apache/airflow/pull/7351#issuecomment-581863929
> @kaxil thanks for suggestions - i accepted your changes, then merged back into one commit + forced pushed to my branch. is that the right way?
Yup :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ryw commented on issue #7351: [AIRFLOW-XXXX] Add
scheduler in production section to best practices doc
Posted by GitBox <gi...@apache.org>.
ryw commented on issue #7351: [AIRFLOW-XXXX] Add scheduler in production section to best practices doc
URL: https://github.com/apache/airflow/pull/7351#issuecomment-581684842
@kaxil thanks for suggestions - i accepted your changes, then merged back into one commit + forced pushed to my branch. is that the right way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7351:
[AIRFLOW-XXXX] Add scheduler in production section to best practices doc
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7351: [AIRFLOW-XXXX] Add scheduler in production section to best practices doc
URL: https://github.com/apache/airflow/pull/7351#discussion_r374380505
##########
File path: docs/best-practices.rst
##########
@@ -315,3 +315,16 @@ Some configurations such as Airflow Backend connection URI can be derived from b
.. code::
sql_alchemy_conn_cmd = bash_command_to_run
+
+
+Scheduler Uptime
+-----------------
+
+Airflow users have for a long time been affected by a
+`core Airflow bug <https://issues.apache.org/jira/browse/AIRFLOW-401>`_
+that causes the scheduler to hang without a trace.
+
+Until fully resolved, you can mitigate a few ways:
+
+* Set a reasonable run_duration setting in your `airflow.cfg`. `See example <https://github.com/astronomer/airflow-chart/blob/63bc503c67e2cd599df0b6f831d470d09bad7ee7/templates/configmap.yaml#L44>`_.
Review comment:
```suggestion
* Set a reasonable run_duration setting in your ``airflow.cfg``. `See example <https://github.com/astronomer/airflow-chart/blob/63bc503c67e2cd599df0b6f831d470d09bad7ee7/templates/configmap.yaml#L44>`_.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7351: [AIRFLOW-XXXX] Add
scheduler in production section to best practices doc
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7351: [AIRFLOW-XXXX] Add scheduler in production section to best practices doc
URL: https://github.com/apache/airflow/pull/7351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ryw commented on issue #7351: [AIRFLOW-XXXX] Add
scheduler in production section to best practices doc
Posted by GitBox <gi...@apache.org>.
ryw commented on issue #7351: [AIRFLOW-XXXX] Add scheduler in production section to best practices doc
URL: https://github.com/apache/airflow/pull/7351#issuecomment-581704942
@kaxil hmm looks like random test fail?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services