[GitHub] [spark] cloud-fan commented on a change in pull request #29544: [SPARK-32704][SQL] Logging plan changes for execution

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #29544:
URL: https://github.com/apache/spark/pull/29544#discussion_r489280396



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -359,7 +359,14 @@ object QueryExecution {
   private[execution] def prepareForExecution(
       preparations: Seq[Rule[SparkPlan]],
       plan: SparkPlan): SparkPlan = {
-    preparations.foldLeft(plan) { case (sp, rule) => rule.apply(sp) }
+    val planChangeLogger = new PlanChangeLogger[SparkPlan]()

Review comment:
       We also run physical rules in `AdaptiveSparkPlanExec`, shall we log plan change there as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org