You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "thswlsqls (via GitHub)" <gi...@apache.org> on 2026/07/03 07:19:28 UTC

[PR] Aliyun: Prefer static credentials over RRSA auto-detection [iceberg]

thswlsqls opened a new pull request, #17048:
URL: https://github.com/apache/iceberg/pull/17048

   
   Closes #17046
   
   ## Summary
   
   - `DefaultAliyunClientFactory.newOSSClient()` always checked RRSA environment variables first, silently overriding explicit `client.access-key-id`/`client.access-key-secret` configuration whenever a pod happened to have RRSA env vars set (e.g. ACK auto-injection).
   - Now RRSA is only used as a fallback when the static credential pair is incomplete (either field missing), matching the precedence in the sibling aws module (`AwsClientProperties#credentialsProvider`, which prefers a fully configured static pair over auto-detection).
   - Existing RRSA-only users (no static credentials configured) see no behavior change.
   
   ## Testing done
   
   - Added `TestAliyunClientFactories#testExplicitStaticCredentialsTakePrecedenceOverRrsa`: RRSA env vars + complete static credentials configured -> static credentials used (no exception from the nonexistent RRSA token file path).
   - Added `TestAliyunClientFactories#testRrsaUsedWhenAccessKeySecretMissing`: RRSA env vars + only `access-key-id` configured (secret missing) -> RRSA path still used, avoiding a regression for incomplete static config.
   - `./gradlew :iceberg-aliyun:check` - 40 existing + 2 new = 42 tests passed (spotlessCheck, checkstyle, errorProne all passed).
   - `iceberg-aliyun` is not a revapi-tracked module; no revapi run needed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Aliyun: Prefer static credentials over RRSA auto-detection [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17048:
URL: https://github.com/apache/iceberg/pull/17048#issuecomment-5363599709

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Aliyun: Prefer static credentials over RRSA auto-detection [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17048:
URL: https://github.com/apache/iceberg/pull/17048#issuecomment-5447802202

   This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Aliyun: Prefer static credentials over RRSA auto-detection [iceberg]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #17048: Aliyun: Prefer static credentials over RRSA auto-detection
URL: https://github.com/apache/iceberg/pull/17048


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org