[GitHub] [incubator-nuttx] curuvar commented on a diff in pull request #6850: Added support for Raspberry Pi Pico W

[GitBox <gi...@apache.org>]

curuvar commented on code in PR #6850:
URL: https://github.com/apache/incubator-nuttx/pull/6850#discussion_r947134825


##########
drivers/wireless/ieee80211/bcm43xxx/Kconfig:
##########
@@ -40,6 +40,35 @@ config IEEE80211_INFINEON_CYW43439
 	default n
 	select IEEE80211_BROADCOM_HAVE_CLM
 
+config CYW43439_FIRMWARE_BIN_PATH
+	string "Path to Infineon 43439 firmware file"
+	depends on IEEE80211_INFINEON_CYW43439
+	default "${PICO_SDK_PATH}/lib/cyw43-driver/firmware/43439A0-7.95.49.00.combined"
+	---help---
+		This should be a path to a file containing both the cyw43439 firmware and
+		the CLB blob.   The firmware should be padded to a 256 byte boundary and
+		then the CLM blob should be appended.
+
+		If this file is updated, check the CYW43439_FIRMWARE_LEN and 
+		CYW43439_CLM_BLOB_LEN below to make sure they reflect the new, un-padded 
+		lengths of the two parts.
+
+config CYW43439_FIRMWARE_LEN

Review Comment:
   The firmware file we get from pico-sdk actually contains two things concatenated together: the actual firmware and the clm blob.  These to parts are copied to the chip by different methods from different functions. Since the location of the firmware file is a configurable item, it seemed reasonable that the length of (at least) the first part was too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org