You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "sollhui (via GitHub)" <gi...@apache.org> on 2025/12/28 03:39:05 UTC

[PR] [fix](transaction) abort txn when coordinate be restart/down should execute before/after abort [doris]

sollhui opened a new pull request, #59425:
URL: https://github.com/apache/doris/pull/59425

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694484859

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3749264016

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1f6e76960db45c80980424f98e2ce913e3ae184b_1f6e76960db45c80980424f98e2ce913e3ae184b/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1f6e76960db45c80980424f98e2ce913e3ae184b_1f6e76960db45c80980424f98e2ce913e3ae184b/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 52.97% (18979/35832) |
   | Line Coverage     | 39.00% (175799/450736) |
   | Region Coverage   | 33.63% (136335/405342) |
   | Branch Coverage   | 34.65% (58903/170006) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694538145

   # FE UT Coverage Report
   Increment line coverage `  0.00% (0/54)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) abort txn when coordinate be restart/down should execute before/after abort [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694469025

   # Cloud UT Coverage Report
   Increment line coverage `0.00% (0/78)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/cb87a3d2df433898416647f9d4feb9cdb92cb71d_cb87a3d2df433898416647f9d4feb9cdb92cb71d_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/cb87a3d2df433898416647f9d4feb9cdb92cb71d_cb87a3d2df433898416647f9d4feb9cdb92cb71d_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.45% (1771/2229) |
   | Line Coverage     | 64.72% (31310/48377) |
   | Region Coverage   | 65.20% (15581/23896) |
   | Branch Coverage   | 55.82% (8285/14842) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694511056

   # Cloud UT Coverage Report
   Increment line coverage `0.00% (0/78)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/2866535f944d50feb173ef5a5efab4736c0461e2_2866535f944d50feb173ef5a5efab4736c0461e2_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/2866535f944d50feb173ef5a5efab4736c0461e2_2866535f944d50feb173ef5a5efab4736c0461e2_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.45% (1771/2229) |
   | Line Coverage     | 64.68% (31290/48377) |
   | Region Coverage   | 65.16% (15571/23896) |
   | Branch Coverage   | 55.76% (8276/14842) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3748823509

   # FE UT Coverage Report
   Increment line coverage `  0.00% (0/54)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694525015

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 180028 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 2866535f944d50feb173ef5a5efab4736c0461e2, data reload: false
   
   query5	4911	595	472	472
   query6	329	232	212	212
   query7	4225	464	279	279
   query8	308	247	230	230
   query9	8777	2540	2547	2540
   query10	515	366	320	320
   query11	15227	14932	15055	14932
   query12	202	123	114	114
   query13	1276	491	390	390
   query14	6240	3054	2765	2765
   query14_1	2778	2708	2658	2658
   query15	219	206	188	188
   query16	866	487	445	445
   query17	1120	728	597	597
   query18	2548	453	344	344
   query19	230	234	207	207
   query20	125	119	119	119
   query21	222	142	120	120
   query22	4071	3968	3919	3919
   query23	16910	16425	15965	15965
   query23_1	16121	16244	16108	16108
   query24	7412	1656	1234	1234
   query24_1	1230	1248	1224	1224
   query25	548	469	409	409
   query26	1258	280	166	166
   query27	2739	467	310	310
   query28	4490	2118	2108	2108
   query29	809	537	431	431
   query30	320	242	211	211
   query31	807	715	640	640
   query32	87	69	71	69
   query33	547	338	280	280
   query34	916	919	541	541
   query35	778	791	717	717
   query36	869	922	821	821
   query37	128	90	73	73
   query38	3005	2965	3025	2965
   query39	778	750	717	717
   query39_1	698	718	706	706
   query40	218	140	120	120
   query41	69	63	64	63
   query42	112	105	106	105
   query43	439	440	415	415
   query44	1317	737	754	737
   query45	190	189	182	182
   query46	883	981	610	610
   query47	1698	1733	1641	1641
   query48	310	330	266	266
   query49	638	451	359	359
   query50	662	321	217	217
   query51	3856	3809	3843	3809
   query52	104	106	97	97
   query53	316	353	295	295
   query54	288	254	255	254
   query55	84	76	79	76
   query56	296	288	305	288
   query57	1164	1153	1084	1084
   query58	284	256	243	243
   query59	2454	2539	2490	2490
   query60	334	329	310	310
   query61	196	186	186	186
   query62	746	706	669	669
   query63	338	301	301	301
   query64	5126	1393	1153	1153
   query65	4027	3957	3967	3957
   query66	1448	441	313	313
   query67	15672	15018	14847	14847
   query68	8358	989	711	711
   query69	494	344	314	314
   query70	1062	1029	971	971
   query71	394	320	283	283
   query72	6071	4897	4916	4897
   query73	680	575	308	308
   query74	8868	8924	8895	8895
   query75	3216	3164	2811	2811
   query76	4010	1165	732	732
   query77	603	408	307	307
   query78	9469	9656	8825	8825
   query79	1582	887	619	619
   query80	701	636	560	560
   query81	519	267	227	227
   query82	202	132	101	101
   query83	256	260	232	232
   query84	264	126	103	103
   query85	886	530	448	448
   query86	395	308	290	290
   query87	3311	3248	3182	3182
   query88	4471	2289	2307	2289
   query89	465	430	399	399
   query90	2198	168	162	162
   query91	181	165	151	151
   query92	95	69	65	65
   query93	1645	907	552	552
   query94	464	312	291	291
   query95	564	383	307	307
   query96	585	493	220	220
   query97	2257	2280	2227	2227
   query98	220	203	194	194
   query99	1342	1336	1299	1299
   Total cold run time: 263862 ms
   Total hot run time: 180028 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694623645

   # FE Regression Coverage Report
   Increment line coverage `  40.74% (22/54)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694485054

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) abort txn when coordinate be restart/down should execute before/after abort [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694476757

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3748921091

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31457 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 1f6e76960db45c80980424f98e2ce913e3ae184b, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17626	4187	4030	4030
   q2	2019	364	238	238
   q3	10165	1264	734	734
   q4	10212	787	314	314
   q5	7497	2102	1893	1893
   q6	200	178	140	140
   q7	948	785	667	667
   q8	9316	1367	1166	1166
   q9	4872	4562	4473	4473
   q10	6775	1819	1395	1395
   q11	530	310	302	302
   q12	698	723	597	597
   q13	17778	3824	3085	3085
   q14	299	290	278	278
   q15	587	512	518	512
   q16	679	674	643	643
   q17	654	781	544	544
   q18	6592	6506	6363	6363
   q19	1097	975	619	619
   q20	391	361	250	250
   q21	2997	2511	2260	2260
   q22	1044	1022	954	954
   Total cold run time: 102976 ms
   Total hot run time: 31457 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4109	4037	4037	4037
   q2	323	392	326	326
   q3	2101	2604	2227	2227
   q4	1353	1785	1320	1320
   q5	4135	4083	4123	4083
   q6	210	168	129	129
   q7	1884	1848	1694	1694
   q8	2871	2574	2493	2493
   q9	7394	7107	7321	7107
   q10	2528	2640	2326	2326
   q11	613	472	478	472
   q12	694	821	621	621
   q13	3692	4057	3516	3516
   q14	302	326	315	315
   q15	550	515	510	510
   q16	669	683	664	664
   q17	1213	1343	1376	1343
   q18	8226	7670	7787	7670
   q19	891	854	837	837
   q20	2016	2054	1954	1954
   q21	4691	4293	4079	4079
   q22	1055	1037	965	965
   Total cold run time: 51520 ms
   Total hot run time: 48688 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3748448304

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3748633627

   # Cloud UT Coverage Report
   Increment line coverage `70.51% (55/78)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/1f6e76960db45c80980424f98e2ce913e3ae184b_1f6e76960db45c80980424f98e2ce913e3ae184b_cloud/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/1f6e76960db45c80980424f98e2ce913e3ae184b_1f6e76960db45c80980424f98e2ce913e3ae184b_cloud/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 79.59% (1786/2244) |
   | Line Coverage     | 64.78% (31790/49075) |
   | Region Coverage   | 65.44% (15827/24185) |
   | Branch Coverage   | 56.04% (8414/15014) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3695334115

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 64.37% (22334/34694) |
   | Line Coverage     | 50.80% (226819/446490) |
   | Region Coverage   | 45.56% (185066/406174) |
   | Branch Coverage   | 46.94% (79561/169504) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3748541588

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694527586

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 28.39 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 2866535f944d50feb173ef5a5efab4736c0461e2, data reload: false
   
   query1	0.05	0.04	0.04
   query2	0.14	0.06	0.07
   query3	0.35	0.08	0.08
   query4	1.61	0.10	0.09
   query5	0.26	0.24	0.24
   query6	1.18	0.65	0.65
   query7	0.03	0.02	0.02
   query8	0.07	0.06	0.06
   query9	0.58	0.49	0.49
   query10	0.56	0.56	0.55
   query11	0.26	0.13	0.13
   query12	0.26	0.14	0.15
   query13	0.63	0.63	0.62
   query14	1.01	1.02	1.00
   query15	0.87	0.83	0.81
   query16	0.40	0.39	0.40
   query17	1.06	1.08	1.06
   query18	0.24	0.22	0.23
   query19	1.94	1.79	1.79
   query20	0.02	0.02	0.01
   query21	15.39	0.28	0.24
   query22	4.96	0.10	0.09
   query23	15.42	0.40	0.22
   query24	2.39	0.46	0.31
   query25	0.10	0.10	0.09
   query26	0.19	0.17	0.17
   query27	0.10	0.09	0.10
   query28	3.84	1.37	1.17
   query29	12.59	4.10	3.30
   query30	0.34	0.12	0.10
   query31	2.82	0.67	0.43
   query32	3.24	0.60	0.49
   query33	3.06	3.06	3.02
   query34	16.83	5.27	4.62
   query35	4.71	4.67	4.60
   query36	0.61	0.50	0.49
   query37	0.24	0.09	0.09
   query38	0.20	0.06	0.05
   query39	0.07	0.05	0.05
   query40	0.20	0.18	0.17
   query41	0.13	0.06	0.06
   query42	0.08	0.06	0.04
   query43	0.06	0.06	0.05
   Total cold run time: 99.09 s
   Total hot run time: 28.39 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694616696

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 64.37% (22334/34694) |
   | Line Coverage     | 50.80% (226819/446490) |
   | Region Coverage   | 45.56% (185066/406174) |
   | Branch Coverage   | 46.94% (79561/169504) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3695345175

   # FE Regression Coverage Report
   Increment line coverage `  12.96% (7/54)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_2866535f944d50feb173ef5a5efab4736c0461e2_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3745486198

   # FE UT Coverage Report
   Increment line coverage `  0.00% (0/54)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_45425df5c5bcc0579dbd765772e14e988834663f/fe_increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_45425df5c5bcc0579dbd765772e14e988834663f/fe_report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3749467198

   # FE Regression Coverage Report
   Increment line coverage `  18.52% (10/54)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694519029

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 36531 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 2866535f944d50feb173ef5a5efab4736c0461e2, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17632	4257	4100	4100
   q2	2040	358	242	242
   q3	10154	1359	746	746
   q4	10227	876	322	322
   q5	7527	2111	2028	2028
   q6	198	173	136	136
   q7	1020	876	723	723
   q8	9413	1448	1154	1154
   q9	7490	5375	5390	5375
   q10	6898	2433	1970	1970
   q11	547	346	318	318
   q12	708	730	579	579
   q13	17805	3684	3037	3037
   q14	292	296	272	272
   q15	597	523	518	518
   q16	704	696	643	643
   q17	702	807	508	508
   q18	7665	7741	7939	7741
   q19	1599	1012	616	616
   q20	406	394	258	258
   q21	4483	4325	4193	4193
   q22	1120	1064	1052	1052
   Total cold run time: 109227 ms
   Total hot run time: 36531 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4434	4198	4311	4198
   q2	349	393	309	309
   q3	2542	2845	2472	2472
   q4	1499	1875	1398	1398
   q5	4868	4357	4627	4357
   q6	208	164	127	127
   q7	2011	1877	1801	1801
   q8	2648	2553	2480	2480
   q9	7497	7665	7668	7665
   q10	2950	3110	2720	2720
   q11	598	521	490	490
   q12	642	695	571	571
   q13	3285	3624	3066	3066
   q14	265	275	274	274
   q15	527	501	484	484
   q16	610	655	603	603
   q17	1099	1246	1318	1246
   q18	7297	7106	6997	6997
   q19	828	806	839	806
   q20	1900	1960	1803	1803
   q21	4638	4273	4169	4169
   q22	1069	1023	979	979
   Total cold run time: 51764 ms
   Total hot run time: 49015 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) abort txn when coordinate be restart/down should execute before/after abort [doris]

Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694421293

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694478616

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3745116504

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3745656946

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31870 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 45425df5c5bcc0579dbd765772e14e988834663f, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17693	4319	4117	4117
   q2	2017	357	238	238
   q3	10369	1290	712	712
   q4	10307	798	316	316
   q5	9264	2103	1887	1887
   q6	221	173	141	141
   q7	966	792	655	655
   q8	9272	1421	1174	1174
   q9	4900	4678	4613	4613
   q10	6825	1808	1417	1417
   q11	515	306	276	276
   q12	733	751	618	618
   q13	17788	3816	3062	3062
   q14	293	291	273	273
   q15	585	511	517	511
   q16	692	685	632	632
   q17	640	738	537	537
   q18	7338	6309	7444	6309
   q19	1578	1037	622	622
   q20	392	385	257	257
   q21	3193	2554	2434	2434
   q22	1156	1137	1069	1069
   Total cold run time: 106737 ms
   Total hot run time: 31870 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4412	4252	4350	4252
   q2	384	441	316	316
   q3	2298	2807	2394	2394
   q4	1432	1883	1521	1521
   q5	4537	4452	4359	4359
   q6	234	170	139	139
   q7	2021	1896	1803	1803
   q8	2600	2446	2444	2444
   q9	7158	7066	7265	7066
   q10	2524	2667	2109	2109
   q11	541	463	433	433
   q12	665	692	597	597
   q13	3330	3772	3048	3048
   q14	270	295	259	259
   q15	524	485	481	481
   q16	630	643	605	605
   q17	1104	1278	1337	1278
   q18	7498	7417	7151	7151
   q19	843	786	792	786
   q20	1866	1979	1831	1831
   q21	4484	4308	4124	4124
   q22	1084	1035	995	995
   Total cold run time: 50439 ms
   Total hot run time: 47991 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3749413597

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.87% (25941/35115) |
   | Line Coverage     | 61.28% (275858/450152) |
   | Region Coverage   | 56.21% (230366/409854) |
   | Branch Coverage   | 58.06% (99157/170771) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3748991006

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 27.88 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 1f6e76960db45c80980424f98e2ce913e3ae184b, data reload: false
   
   query1	0.05	0.05	0.05
   query2	0.14	0.07	0.07
   query3	0.32	0.08	0.07
   query4	1.63	0.09	0.10
   query5	0.26	0.25	0.25
   query6	1.14	0.65	0.65
   query7	0.03	0.02	0.02
   query8	0.07	0.06	0.05
   query9	0.58	0.52	0.50
   query10	0.56	0.56	0.54
   query11	0.25	0.13	0.14
   query12	0.26	0.13	0.14
   query13	0.62	0.62	0.61
   query14	0.97	0.98	0.97
   query15	0.89	0.82	0.82
   query16	0.40	0.43	0.40
   query17	1.05	1.07	1.04
   query18	0.24	0.23	0.23
   query19	1.92	1.85	1.83
   query20	0.02	0.02	0.01
   query21	15.39	0.29	0.24
   query22	4.97	0.09	0.09
   query23	15.44	0.40	0.22
   query24	2.35	0.51	0.33
   query25	0.11	0.10	0.10
   query26	0.18	0.17	0.16
   query27	0.10	0.09	0.09
   query28	3.61	1.13	0.97
   query29	12.51	4.05	3.23
   query30	0.32	0.13	0.11
   query31	2.81	0.67	0.42
   query32	3.24	0.62	0.51
   query33	3.04	3.05	3.08
   query34	16.51	5.11	4.45
   query35	4.48	4.55	4.45
   query36	0.61	0.49	0.49
   query37	0.27	0.09	0.09
   query38	0.21	0.05	0.06
   query39	0.07	0.06	0.05
   query40	0.20	0.17	0.16
   query41	0.13	0.07	0.06
   query42	0.08	0.05	0.05
   query43	0.06	0.06	0.05
   Total cold run time: 98.09 s
   Total hot run time: 27.88 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3746012564

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/45425df5c5bcc0579dbd765772e14e988834663f_45425df5c5bcc0579dbd765772e14e988834663f/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/45425df5c5bcc0579dbd765772e14e988834663f_45425df5c5bcc0579dbd765772e14e988834663f/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 53.00% (18976/35806) |
   | Line Coverage     | 39.05% (175900/450431) |
   | Region Coverage   | 33.64% (136220/404880) |
   | Branch Coverage   | 34.66% (58876/169855) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) abort txn when coordinate be restart/down should execute before/after abort [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694421346

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) abort txn when coordinate be restart/down should execute before/after abort [doris]

Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694447874

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3694552445

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/2866535f944d50feb173ef5a5efab4736c0461e2_2866535f944d50feb173ef5a5efab4736c0461e2/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/2866535f944d50feb173ef5a5efab4736c0461e2_2866535f944d50feb173ef5a5efab4736c0461e2/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 53.41% (18953/35489) |
   | Line Coverage     | 39.28% (175829/447682) |
   | Region Coverage   | 33.85% (136088/402009) |
   | Branch Coverage   | 34.77% (58746/168940) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3752871451

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3752871527

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #59425:
URL: https://github.com/apache/doris/pull/59425


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3745697195

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 172212 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 45425df5c5bcc0579dbd765772e14e988834663f, data reload: false
   
   query5	4434	612	453	453
   query6	330	241	217	217
   query7	4217	463	251	251
   query8	342	254	248	248
   query9	8723	2876	2870	2870
   query10	504	370	318	318
   query11	15236	15080	14980	14980
   query12	168	118	123	118
   query13	1266	490	376	376
   query14	6117	3022	2697	2697
   query14_1	2632	2591	2615	2591
   query15	205	189	171	171
   query16	1001	504	467	467
   query17	1076	647	545	545
   query18	2446	419	330	330
   query19	231	222	188	188
   query20	124	116	115	115
   query21	212	133	125	125
   query22	3908	3867	3740	3740
   query23	16026	15666	15371	15371
   query23_1	15214	15585	15342	15342
   query24	7135	1549	1147	1147
   query24_1	1171	1137	1172	1137
   query25	555	485	427	427
   query26	1256	262	161	161
   query27	2763	425	269	269
   query28	4623	2166	2149	2149
   query29	765	546	466	466
   query30	312	241	212	212
   query31	829	633	546	546
   query32	81	74	70	70
   query33	527	351	295	295
   query34	912	873	516	516
   query35	727	753	665	665
   query36	897	896	785	785
   query37	137	95	84	84
   query38	2748	2688	2627	2627
   query39	780	750	728	728
   query39_1	734	728	706	706
   query40	221	132	116	116
   query41	65	62	60	60
   query42	107	101	107	101
   query43	440	443	399	399
   query44	1324	742	732	732
   query45	191	182	177	177
   query46	813	937	557	557
   query47	1416	1496	1349	1349
   query48	294	315	226	226
   query49	619	419	338	338
   query50	610	286	203	203
   query51	3775	3745	3699	3699
   query52	106	107	98	98
   query53	309	329	279	279
   query54	289	264	257	257
   query55	81	76	77	76
   query56	298	315	310	310
   query57	1029	1014	943	943
   query58	274	260	253	253
   query59	2075	2158	2145	2145
   query60	335	338	312	312
   query61	157	182	156	156
   query62	395	368	301	301
   query63	299	263	272	263
   query64	4913	1273	959	959
   query65	3820	3765	3756	3756
   query66	1446	417	310	310
   query67	15214	14779	14760	14760
   query68	2785	1007	722	722
   query69	453	366	319	319
   query70	1043	856	943	856
   query71	333	304	288	288
   query72	5601	3393	3638	3393
   query73	559	691	304	304
   query74	8784	8828	8532	8532
   query75	2775	2822	2455	2455
   query76	2372	1046	651	651
   query77	373	395	311	311
   query78	9865	9856	9201	9201
   query79	1029	955	572	572
   query80	693	626	518	518
   query81	474	272	237	237
   query82	1332	149	113	113
   query83	373	265	249	249
   query84	259	121	102	102
   query85	910	501	446	446
   query86	363	305	293	293
   query87	2892	2858	2817	2817
   query88	2904	2136	2124	2124
   query89	382	348	326	326
   query90	1917	160	154	154
   query91	171	160	137	137
   query92	79	74	66	66
   query93	913	912	519	519
   query94	457	322	296	296
   query95	588	330	306	306
   query96	562	474	198	198
   query97	2351	2351	2311	2311
   query98	207	205	202	202
   query99	610	555	493	493
   Total cold run time: 245846 ms
   Total hot run time: 172212 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3748963965

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 173415 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 1f6e76960db45c80980424f98e2ce913e3ae184b, data reload: false
   
   query5	4450	619	512	512
   query6	335	227	210	210
   query7	4219	465	253	253
   query8	330	246	239	239
   query9	8693	2874	2864	2864
   query10	508	386	338	338
   query11	15390	15122	14915	14915
   query12	175	117	110	110
   query13	1253	503	402	402
   query14	5939	2967	2754	2754
   query14_1	2680	2649	2693	2649
   query15	199	193	176	176
   query16	992	502	467	467
   query17	1115	671	589	589
   query18	2430	435	343	343
   query19	229	227	201	201
   query20	121	117	112	112
   query21	212	142	123	123
   query22	4054	3984	4053	3984
   query23	16049	15600	15192	15192
   query23_1	15401	15439	15504	15439
   query24	7159	1520	1163	1163
   query24_1	1160	1164	1189	1164
   query25	586	480	455	455
   query26	1249	260	156	156
   query27	2763	448	276	276
   query28	4553	2129	2122	2122
   query29	767	507	423	423
   query30	302	239	207	207
   query31	799	621	546	546
   query32	82	75	77	75
   query33	530	340	299	299
   query34	909	859	520	520
   query35	730	767	675	675
   query36	866	905	850	850
   query37	130	93	86	86
   query38	2683	2717	2659	2659
   query39	765	748	726	726
   query39_1	696	702	721	702
   query40	216	135	116	116
   query41	67	62	62	62
   query42	102	104	107	104
   query43	449	418	409	409
   query44	1321	737	727	727
   query45	185	182	175	175
   query46	819	928	558	558
   query47	1419	1460	1314	1314
   query48	315	325	248	248
   query49	617	422	338	338
   query50	599	277	211	211
   query51	3880	3788	3742	3742
   query52	101	103	95	95
   query53	293	326	273	273
   query54	341	266	263	263
   query55	81	79	76	76
   query56	299	296	331	296
   query57	1048	1022	884	884
   query58	276	252	256	252
   query59	2211	2206	2025	2025
   query60	332	342	328	328
   query61	162	158	163	158
   query62	382	347	310	310
   query63	298	255	277	255
   query64	5035	1310	988	988
   query65	3759	3778	3747	3747
   query66	1456	425	319	319
   query67	14958	15148	14797	14797
   query68	4654	1005	723	723
   query69	518	369	326	326
   query70	1048	951	943	943
   query71	347	304	293	293
   query72	5740	3338	3536	3338
   query73	793	714	316	316
   query74	8703	8660	8543	8543
   query75	2831	2848	2439	2439
   query76	3384	1082	635	635
   query77	541	400	299	299
   query78	9691	9800	9251	9251
   query79	1333	902	566	566
   query80	670	594	481	481
   query81	488	263	225	225
   query82	212	143	111	111
   query83	266	253	246	246
   query84	261	117	103	103
   query85	891	519	456	456
   query86	334	302	286	286
   query87	2829	2889	2758	2758
   query88	3449	2586	2577	2577
   query89	391	336	324	324
   query90	2010	169	164	164
   query91	173	166	141	141
   query92	76	72	66	66
   query93	923	896	521	521
   query94	570	330	301	301
   query95	607	340	372	340
   query96	640	509	232	232
   query97	2321	2415	2329	2329
   query98	215	193	199	193
   query99	582	570	522	522
   Total cold run time: 248678 ms
   Total hot run time: 173415 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3749671175

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.87% (25941/35115) |
   | Line Coverage     | 61.28% (275858/450152) |
   | Region Coverage   | 56.21% (230366/409854) |
   | Branch Coverage   | 58.06% (99157/170771) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](transaction) ensure executing before/after abort when abort transaction in cloud mode [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59425:
URL: https://github.com/apache/doris/pull/59425#issuecomment-3749737041

   # FE Regression Coverage Report
   Increment line coverage `  18.52% (10/54)` :tada:
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b_merge_fe/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/59425_1f6e76960db45c80980424f98e2ce913e3ae184b_merge_fe/report/index.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org