[GitHub] [jackrabbit-oak] mreutegg commented on pull request #1011: OAK-10334: Node.addMixin() may overwrite existing mixins

["mreutegg (via GitHub)" <gi...@apache.org>]

mreutegg commented on PR #1011:
URL: https://github.com/apache/jackrabbit-oak/pull/1011#issuecomment-1701139009

   >  It looks like NodeDelegate.removeMixin has some check to see if the to-be-removed mixin is actually part of the current mixin list - and that check is IIUC done with the actual session permission. So in the write-but-no-read-permission case that would probably fail there.
   
   That's correct.
   
   > But if addMixin now becomes more tolerant, then wouldn't removeMixin also need to be more tolerant?
   
   Yes, I agree, but I rather handle this in a separate issue. The impact is a bit different. Removing a mixin would fail and not result in an unintentional change like in the addMixin() case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org