[GitHub] [arrow] omrimallis commented on pull request #34511: GH-29105: [C++][Parquet] Relax schema checking when writing using StreamWriter

["omrimallis (via GitHub)" <gi...@apache.org>]

omrimallis commented on PR #34511:
URL: https://github.com/apache/arrow/pull/34511#issuecomment-1462192282

   > Maybe we should use LogicalType to check within writer, and encapsulate the convert logic in reader?
   
   Makes sense, converted type is only for backward compatibility according to the spec.
   
   > Seems LogicalType::is_compatible maybe ok here?
   
   I don't think that it can be used here because the `PrimitiveNode` that is being checked might have its `LogicalType` set to null (e.g. in case of a native type like int32 or int64). It is probably better to just do a quick comparison of `LogicalType::Type`. I can give it a try and push an update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org