[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3781: [test/plugin] Not support copy all optional plugins

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #3781: [test/plugin] Not support copy all optional plugins
URL: https://github.com/apache/skywalking/pull/3781#discussion_r342083416
 
 

 ##########
 File path: test/plugin/run.sh
 ##########
 @@ -172,9 +172,8 @@ running_mode=$(grep "^runningMode" ${scenario_home}/configuration.yml |sed -e "s
 with_plugins=$(grep "^withPlugins" ${scenario_home}/configuration.yml |sed -e "s/ //g" |awk -F: '{print $2}')
 
 if [[ -n "${running_mode}" ]]; then
-    # [[ -z "${with_plugins}" ]] ; then&& exitWithMessage \
-    #    "'withPlugins' has required configuration when 'runningMode' was set as 'optional_plugins' or 'bootstrap_plugins'"
-    [[ -z "${with_plugins}" ]] && with_plugins="*.jar"
+    [[ -z "${with_plugins}" ]] && exitWithMessage \
+       "'withPlugins' has required configuration when 'runningMode' was set as 'optional_plugins' or 'bootstrap_plugins'"
 
 Review comment:
   ```suggestion
          "'withPlugins' is required configuration when 'runningMode' was set as 'optional_plugins' or 'bootstrap_plugins'"
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services