You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/05/18 05:13:57 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on pull request #2734: remove unnecessary lock & fix syncWorkerHostWeight variable reference
codecov-io commented on pull request #2734:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2734#issuecomment-629950104
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734?src=pr&el=h1) Report
> Merging [#2734](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1771aa50d5f00e30fd0ac1e166206c9e2b8e2001&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #2734 +/- ##
============================================
+ Coverage 37.17% 37.19% +0.01%
Complexity 2553 2553
============================================
Files 434 434
Lines 19977 19972 -5
Branches 2423 2423
============================================
+ Hits 7427 7429 +2
+ Misses 11882 11878 -4
+ Partials 668 665 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...r/master/dispatch/host/LowerWeightHostManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L0xvd2VyV2VpZ2h0SG9zdE1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `25.71% <0.00%> (-5.72%)` | `5.00% <0.00%> (-1.00%)` | |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `52.51% <0.00%> (+1.43%)` | `10.00% <0.00%> (+1.00%)` | |
| [...he/dolphinscheduler/common/thread/ThreadUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9UaHJlYWRVdGlscy5qYXZh) | `74.60% <0.00%> (+3.17%)` | `14.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734?src=pr&el=footer). Last update [1771aa5...1864f87](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/2734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org