You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/10 12:52:45 UTC

[GitHub] [superset] geido commented on a change in pull request #17690: fix: Dashboard header negative margin on save

geido commented on a change in pull request #17690:
URL: https://github.com/apache/superset/pull/17690#discussion_r766654205



##########
File path: superset-frontend/src/components/EditableTitle/index.tsx
##########
@@ -18,8 +18,9 @@
  */
 import React, { useEffect, useState, useRef } from 'react';
 import cx from 'classnames';
-import { t } from '@superset-ui/core';
+import { styled, t } from '@superset-ui/core';
 import { Tooltip } from 'src/components/Tooltip';
+import CertifiedIcon from '../CertifiedIcon';

Review comment:
       @rusackas I think the name is misleading here. This is intended to be more than just an icon, it's more like a tiny component.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org