[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #477: [ISSUE #476] Biz Exceptions occured in EventMesh cause connection close of client

[GitBox <gi...@apache.org>]

ruanwenjun commented on a change in pull request #477:
URL: https://github.com/apache/incubator-eventmesh/pull/477#discussion_r680365514



##########
File path: eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/EventMeshTcpMessageDispatcher.java
##########
@@ -77,8 +76,45 @@ protected void channelRead0(ChannelHandlerContext ctx, Package pkg) throws Excep
             dispatch(ctx, pkg, startTime, cmd);
         } catch (Exception e) {
             logger.error("exception occurred while pkg|cmd={}|pkg={}|errMsg={}", cmd, pkg, e);

Review comment:
       The `errMsg={}` in the error log is redundant. It is better midify to 
   ```java
   logger.error("exception occurred while pkg|cmd={}|pkg={}", cmd, pkg, e);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org