[jira] [Updated] (KAFKA-943) Move all configuration key string to constants

["Sam Meder (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KAFKA-943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sam Meder updated KAFKA-943:
----------------------------

    Resolution: Won't Fix
        Status: Resolved  (was: Patch Available)

Resolving this issue since the patch wasn't accepted. I'll open a new issue for the strict validation patch
                
> Move all configuration key string to constants
> ----------------------------------------------
>
>                 Key: KAFKA-943
>                 URL: https://issues.apache.org/jira/browse/KAFKA-943
>             Project: Kafka
>          Issue Type: Improvement
>          Components: config
>    Affects Versions: 0.8
>            Reporter: Sam Meder
>         Attachments: configConstants.patch
>
>
> The current code base has configuration key strings duplicated all over the place. They show up in the actual *Config classes, a lot of tests, command line utilities and other examples. This makes changes hard and error prone. DRY...
> The attached patch moves these configuration keys to constants and replaces their usage with a reference to the constant. It also cleans up a few old properties and a few misconfigured tests. I've admittedly not written a whole lot of Scala, so there may be some improvements that can be made, in particular I am not sure I chose the best strategy for keys needed by the SyncProducerConfigShared trait (or traits in general).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira