You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/04 05:18:01 UTC
[GitHub] [tvm] haoyang9804 opened a new pull request #10484: Add Check about negative uint
haoyang9804 opened a new pull request #10484:
URL: https://github.com/apache/tvm/pull/10484
Focusing the problem in [here](https://discuss.tvm.apache.org/t/check-failed-value-0u-1-vs-0-at-relay-build/12223). I have make the following change to the codebase:
In `TryConstFold<tir::Sub>`, which is needed for `negative` operator, I add a check about potential negative uint value: If minuend is of uint and it's value is 0 while the subtrahend is of uint, then the difference would be negative and of uint. This situation should be forbidden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #10484: Add Check about negative uint constant
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #10484:
URL: https://github.com/apache/tvm/pull/10484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] haoyang9804 commented on pull request #10484: Add Check about negative uint constant
Posted by GitBox <gi...@apache.org>.
haoyang9804 commented on pull request #10484:
URL: https://github.com/apache/tvm/pull/10484#issuecomment-1061327761
Hi @masahi. Would you mind to take a look at this pr. Maybe it's a small problem, but I think it shows an inconsistency between uint const and uint var.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leeexyz commented on pull request #10484: Add Check about negative uint
Posted by GitBox <gi...@apache.org>.
leeexyz commented on pull request #10484:
URL: https://github.com/apache/tvm/pull/10484#issuecomment-1058876349
@haoyang9804 You can find the Sanity Check Log [here](https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-10484/5/pipeline).
change
```c++
[2022-03-04T06:18:11.419Z] - ICHECK(!(pa && pa->dtype.is_uint() && pa->value == 0U && b.dtype().is_uint())) << \
[2022-03-04T06:18:11.419Z] - "Checked failed. Minuend 's value is 0U and it's dtype is uint " << \
[2022-03-04T06:18:11.419Z] - "while Subtrahend's dtype is uint; which will cause a negative unit";
```
to
```c++
[2022-03-04T06:18:11.419Z] + ICHECK(!(pa && pa->dtype.is_uint() && pa->value == 0U && b.dtype().is_uint()))
[2022-03-04T06:18:11.419Z] + << "Checked failed. Minuend 's value is 0U and it's dtype is uint "
[2022-03-04T06:18:11.419Z] + << "while Subtrahend's dtype is uint; which will cause a negative uint";
```
You'd better run the check locally before sending a PR.
```bash
bash ./tests/scripts/task_lint.sh
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] haoyang9804 closed pull request #10484: Add Check about negative uint
Posted by GitBox <gi...@apache.org>.
haoyang9804 closed pull request #10484:
URL: https://github.com/apache/tvm/pull/10484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] haoyang9804 commented on pull request #10484: Add Check about negative uint
Posted by GitBox <gi...@apache.org>.
haoyang9804 commented on pull request #10484:
URL: https://github.com/apache/tvm/pull/10484#issuecomment-1058842055
Could any reviewer help take a look about why my commit fails in sanity check? I do not have adequate experience in commiting fixes. Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] haoyang9804 commented on pull request #10484: Add Check about negative uint
Posted by GitBox <gi...@apache.org>.
haoyang9804 commented on pull request #10484:
URL: https://github.com/apache/tvm/pull/10484#issuecomment-1058877611
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] haoyang9804 edited a comment on pull request #10484: Add Check about negative uint
Posted by GitBox <gi...@apache.org>.
haoyang9804 edited a comment on pull request #10484:
URL: https://github.com/apache/tvm/pull/10484#issuecomment-1058842055
Could any reviewer help take a look about why my commit fails in sanity check? I do not have adequate experience in commiting fixes. Thanks in advance. cc @junrushao1994 @jroesch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] haoyang9804 commented on pull request #10484: Add Check about negative uint
Posted by GitBox <gi...@apache.org>.
haoyang9804 commented on pull request #10484:
URL: https://github.com/apache/tvm/pull/10484#issuecomment-1058887021
@leeexyz Thanks for you kind reply. Though I cannot run this lint script locally due to inaccessibility of some files. But finally it works after I change the format of the code.
BTW, could you please help check my commit? I am not sure whether or not my fix violates some principles of TVM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org