You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by fidget83 <gi...@git.apache.org> on 2016/09/22 15:19:13 UTC
[GitHub] nifi pull request #1047: Fix creating NiFi RPM
GitHub user fidget83 opened a pull request:
https://github.com/apache/nifi/pull/1047
Fix creating NiFi RPM
I've added script nifi_env.sh to bin directory and fixed jars in /lib and /lib/bootstrap directories.
Now if I installed NiFi from rpm, its run correctly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fidget83/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1047.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1047
----
commit fb0d054332470ff7331ddb90782b34aeb1b833d8
Author: Artem Ermakov <ae...@odin.com>
Date: 2016-09-22T15:15:21Z
Fix creating NiFi RPM
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: Fix creating NiFi RPM
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1047
@fidget83 thank you for the contribution, can you please create a JIRA that describes the problem this is trying to fix? and then update this PR to include the JIRA number. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1047
Notes:
* created RPM.
* did diff between RPM with RPM profile and TGZ without the RPM profile
* installed from the RPM. started NiFi. Connected to it.
LGTM, will merge later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by fidget83 <gi...@git.apache.org>.
Github user fidget83 commented on the issue:
https://github.com/apache/nifi/pull/1047
@bbende, Jira issue is https://issues.apache.org/jira/browse/NIFI-2812
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1047
@trixpan please make sure that commit log entries indicate/start with the JIRA.
This would be in this case
NIFI-2812 This closes #1047. Fixes rpm includes/excludes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1047
@fidget83 - thanks for the contribution.
@joaohf - muito obrigadopelo feedback. :wink:
Notes: created RPM. did diff between LGTM, will merge later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1047#discussion_r80255471
--- Diff: nifi-assembly/pom.xml ---
@@ -505,11 +510,18 @@ language governing permissions and limitations under the License. -->
<directory>/opt/nifi/nifi-${project.version}/lib</directory>
<dependency>
<excludes>
+ <exclude>net.minidev:asm</exclude>
+ <exclude>asm:asm</exclude>
+ <exclude>org.bouncycastle:bcpkix-jdk15on</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-core</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-databind</exclude>
+ <exclude>com.jayway.jsonpath:json-path</exclude>
+ <exclude>net.minidev:json-smart</exclude>
<exclude>org.apache.nifi:nifi-bootstrap</exclude>
<exclude>org.apache.nifi:nifi-resources</exclude>
<exclude>org.apache.nifi:nifi-docs</exclude>
<exclude>commons-io:commons-io</exclude>
- <exclude>org.apache.commons:commons-lang3</exclude>
--- End diff --
seems to be present in the tar file but no longer added to the rpm?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1047#discussion_r80253235
--- Diff: nifi-assembly/pom.xml ---
@@ -505,11 +510,18 @@ language governing permissions and limitations under the License. -->
<directory>/opt/nifi/nifi-${project.version}/lib</directory>
<dependency>
<excludes>
+ <exclude>net.minidev:asm</exclude>
--- End diff --
are you sure this is necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1047#discussion_r80255224
--- Diff: nifi-assembly/pom.xml ---
@@ -505,11 +510,18 @@ language governing permissions and limitations under the License. -->
<directory>/opt/nifi/nifi-${project.version}/lib</directory>
<dependency>
<excludes>
+ <exclude>net.minidev:asm</exclude>
+ <exclude>asm:asm</exclude>
+ <exclude>org.bouncycastle:bcpkix-jdk15on</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-core</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-databind</exclude>
+ <exclude>com.jayway.jsonpath:json-path</exclude>
--- End diff --
seems to be absent from tar file? Sure it is required?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1047#discussion_r80255200
--- Diff: nifi-assembly/pom.xml ---
@@ -505,11 +510,18 @@ language governing permissions and limitations under the License. -->
<directory>/opt/nifi/nifi-${project.version}/lib</directory>
<dependency>
<excludes>
+ <exclude>net.minidev:asm</exclude>
+ <exclude>asm:asm</exclude>
+ <exclude>org.bouncycastle:bcpkix-jdk15on</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-core</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-databind</exclude>
--- End diff --
seems to be absent from tar file? Sure it is required?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1047
@fidget83 would you mind amending the commit message and adding reference to the JIRA you mentioned above?
You can do so by running `git commit --amend`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by fidget83 <gi...@git.apache.org>.
Github user fidget83 commented on the issue:
https://github.com/apache/nifi/pull/1047
@trixpan, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1047
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by joaohf <gi...@git.apache.org>.
Github user joaohf commented on the issue:
https://github.com/apache/nifi/pull/1047
Hi,
I've tested this and the output files from rpm package is the same of tar.gz.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1047#discussion_r80255144
--- Diff: nifi-assembly/pom.xml ---
@@ -505,11 +510,18 @@ language governing permissions and limitations under the License. -->
<directory>/opt/nifi/nifi-${project.version}/lib</directory>
<dependency>
<excludes>
+ <exclude>net.minidev:asm</exclude>
+ <exclude>asm:asm</exclude>
+ <exclude>org.bouncycastle:bcpkix-jdk15on</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
--- End diff --
seems to be absent from tar file? Sure it is required?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1047#discussion_r80255251
--- Diff: nifi-assembly/pom.xml ---
@@ -505,11 +510,18 @@ language governing permissions and limitations under the License. -->
<directory>/opt/nifi/nifi-${project.version}/lib</directory>
<dependency>
<excludes>
+ <exclude>net.minidev:asm</exclude>
+ <exclude>asm:asm</exclude>
+ <exclude>org.bouncycastle:bcpkix-jdk15on</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-core</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-databind</exclude>
+ <exclude>com.jayway.jsonpath:json-path</exclude>
+ <exclude>net.minidev:json-smart</exclude>
--- End diff --
seems to be absent from tar file? Sure it is required?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by fidget83 <gi...@git.apache.org>.
Github user fidget83 commented on the issue:
https://github.com/apache/nifi/pull/1047
@trixpan, I just unified the list of jars in rpm and in created .tar.gz.file. I didn't analyze necessary of each jar, but with this set nifi works :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1047#discussion_r80255166
--- Diff: nifi-assembly/pom.xml ---
@@ -505,11 +510,18 @@ language governing permissions and limitations under the License. -->
<directory>/opt/nifi/nifi-${project.version}/lib</directory>
<dependency>
<excludes>
+ <exclude>net.minidev:asm</exclude>
+ <exclude>asm:asm</exclude>
+ <exclude>org.bouncycastle:bcpkix-jdk15on</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude>
+ <exclude>com.fasterxml.jackson.core:jackson-core</exclude>
--- End diff --
seems to be absent from tar file? Sure it is required?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1047
@fidget83 the JARs should not be unified, instead only the appropriate JARs should go into each directory. Would you mind amending your commit?
Kind regards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1047#discussion_r80253174
--- Diff: nifi-assembly/pom.xml ---
@@ -505,11 +510,18 @@ language governing permissions and limitations under the License. -->
<directory>/opt/nifi/nifi-${project.version}/lib</directory>
<dependency>
<excludes>
+ <exclude>net.minidev:asm</exclude>
+ <exclude>asm:asm</exclude>
--- End diff --
are you sure this is necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---