You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/16 21:07:18 UTC
[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5156:
Move SegmentMetadata from pinot-common to pinot-core
Jackie-Jiang opened a new pull request #5156: Move SegmentMetadata from pinot-common to pinot-core
URL: https://github.com/apache/incubator-pinot/pull/5156
This PR only moves the class into another package, no actual code change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request
#5156: Move SegmentMetadata from pinot-common to pinot-core
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #5156: Move SegmentMetadata from pinot-common to pinot-core
URL: https://github.com/apache/incubator-pinot/pull/5156#discussion_r393351745
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/segment/index/metadata/SegmentMetadata.java
##########
@@ -28,6 +29,7 @@
/**
* The <code>SegmentMetadata</code> class holds the segment level management information and data statistics.
*/
+@InterfaceAudience.Private
Review comment:
phew! thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5156: Move
SegmentMetadata from pinot-common to pinot-core
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #5156: Move SegmentMetadata from pinot-common to pinot-core
URL: https://github.com/apache/incubator-pinot/pull/5156#issuecomment-599794730
> Is this in preparation towards some other change?
Yes, and we have been wanting to do this for a long time, and now all the references to SegmentMetadata in pinot-common are finally cleared.
> Will people's hadoop/spark job builds break because of this?
Should not because in order to build the pinot segment, we always need to import pinot-core.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5156: Move
SegmentMetadata from pinot-common to pinot-core
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #5156: Move SegmentMetadata from pinot-common to pinot-core
URL: https://github.com/apache/incubator-pinot/pull/5156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on issue #5156: Move
SegmentMetadata from pinot-common to pinot-core
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5156: Move SegmentMetadata from pinot-common to pinot-core
URL: https://github.com/apache/incubator-pinot/pull/5156#issuecomment-599785980
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5156?src=pr&el=h1) Report
> Merging [#5156](https://codecov.io/gh/apache/incubator-pinot/pull/5156?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/be37b56c8cb2036397eeafb070355dde704367ed&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/5156?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5156 +/- ##
============================================
- Coverage 66.05% 66.05% -0.01%
Complexity 12 12
============================================
Files 1050 1050
Lines 54113 54113
Branches 8071 8071
============================================
- Hits 35745 35742 -3
- Misses 15709 15713 +4
+ Partials 2659 2658 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5156?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/api/resources/LLCSegmentCompletionHandlers.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0xMQ1NlZ21lbnRDb21wbGV0aW9uSGFuZGxlcnMuamF2YQ==) | `61.80% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ces/PinotSegmentUploadDownloadRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFVwbG9hZERvd25sb2FkUmVzdGxldFJlc291cmNlLmphdmE=) | `63.19% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../pinot/controller/api/upload/SegmentValidator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1NlZ21lbnRWYWxpZGF0b3IuamF2YQ==) | `62.50% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/pinot/controller/api/upload/ZKOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvdXBsb2FkL1pLT3BlcmF0b3IuamF2YQ==) | `76.92% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ntroller/helix/core/PinotHelixResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90SGVsaXhSZXNvdXJjZU1hbmFnZXIuamF2YQ==) | `62.12% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../core/realtime/PinotLLCRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90TExDUmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `74.59% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../realtime/segment/CommittingSegmentDescriptor.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL3NlZ21lbnQvQ29tbWl0dGluZ1NlZ21lbnREZXNjcmlwdG9yLmphdmE=) | `81.25% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ot/controller/helix/core/util/ZKMetadataUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvWktNZXRhZGF0YVV0aWxzLmphdmE=) | `65.51% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ot/core/data/readers/PinotSegmentColumnReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUGlub3RTZWdtZW50Q29sdW1uUmVhZGVyLmphdmE=) | `72.13% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ot/core/data/readers/PinotSegmentRecordReader.java](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3JlYWRlcnMvUGlub3RTZWdtZW50UmVjb3JkUmVhZGVyLmphdmE=) | `90.90% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [65 more](https://codecov.io/gh/apache/incubator-pinot/pull/5156/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5156?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5156?src=pr&el=footer). Last update [be37b56...c639c9c](https://codecov.io/gh/apache/incubator-pinot/pull/5156?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org