You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/20 01:54:48 UTC

[GitHub] [airflow] o-nikolas opened a new pull request, #26510: isort is now a dev dependency, add it to devel in setup.py

o-nikolas opened a new pull request, #26510:
URL: https://github.com/apache/airflow/pull/26510

   I was creating a DB migration today (`alembic revision -m "<my description here>"`) and the post write script was failing since it could not find the `isort` module. I made sure my dev virtualenv was up to date (`pip install --upgrade -e ".[devel,<OTHER EXTRAS>]"`) but still got the issue. It seems that setup.py does not include `isort` as a dependency, though it seems that it should be (after the PEP 563 work). This PR adds it to `devel`
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #26510: isort is now a dev dependency, add it to devel in setup.py

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26510:
URL: https://github.com/apache/airflow/pull/26510#issuecomment-1251957044

   Thanks @o-nikolas !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #26510: isort is now a dev dependency, add it to devel in setup.py

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26510:
URL: https://github.com/apache/airflow/pull/26510#issuecomment-1251956505

   Hmm that was not generrated by PEP653, it should have been there since 2019 :)  - it's driven by alembic.ini "[post_write_hooks]" :) . But yeah - isort was definitely missing in devel :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #26510: isort is now a dev dependency, add it to devel in setup.py

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26510:
URL: https://github.com/apache/airflow/pull/26510


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org