You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/25 05:58:08 UTC

[GitHub] [apisix] spacewander commented on a diff in pull request #7240: feat: allow APISIX_PROFILE to be an empty string

spacewander commented on code in PR #7240:
URL: https://github.com/apache/apisix/pull/7240#discussion_r954530911


##########
t/core/profile.t:
##########
@@ -32,3 +32,19 @@ __DATA__
 --- request
 GET /t
 --- error_code: 404
+
+=== TEST 2: set env "APISIX_PROFILE" to Empty String
+--- config
+    location /t {
+        content_by_lua_block {
+            local profile = require("apisix.core.profile")
+            profile.apisix_home = "./test/"
+            profile.profile = ""

Review Comment:
   We can check if `profile.profile` is equal to `""` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org