You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ro...@apache.org on 2022/07/25 21:46:47 UTC
[arrow] branch master updated: ARROW-17197: [R] floor_date/ceiling_date lubridate comparison tests failing on macOS (#13705)
This is an automated email from the ASF dual-hosted git repository.
rok pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 4e37149615 ARROW-17197: [R] floor_date/ceiling_date lubridate comparison tests failing on macOS (#13705)
4e37149615 is described below
commit 4e37149615da8f55b7e72f469248834d98502c7b
Author: Rok Mihevc <ro...@mihevc.org>
AuthorDate: Mon Jul 25 23:46:41 2022 +0200
ARROW-17197: [R] floor_date/ceiling_date lubridate comparison tests failing on macOS (#13705)
This resolves [ARROW-17197](https://issues.apache.org/jira/browse/ARROW-17197).
Authored-by: Rok <ro...@mihevc.org>
Signed-off-by: Rok <ro...@mihevc.org>
---
r/tests/testthat/test-dplyr-funcs-datetime.R | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/r/tests/testthat/test-dplyr-funcs-datetime.R b/r/tests/testthat/test-dplyr-funcs-datetime.R
index 0c655e48bb..b8bd28e970 100644
--- a/r/tests/testthat/test-dplyr-funcs-datetime.R
+++ b/r/tests/testthat/test-dplyr-funcs-datetime.R
@@ -3138,12 +3138,12 @@ test_that("temporal round/floor/ceil period unit maxima are enforced", {
# produces incorrect answers
check_timezone_rounding_vs_lubridate <- function(data, unit) {
- # esoteric lubridate bug: on windows only (not ubuntu), lubridate returns
+ # esoteric lubridate bug: on windows and macOS (not linux), lubridate returns
# incorrect ceiling/floor for timezoned POSIXct times (syd, adl, kat zones,
# but not mar) but not utc, and not for round, and only for these two
# timestamps where high-precision timing is relevant to the outcome
if (unit %in% c(".001 second", "second", "minute")) {
- if (tolower(Sys.info()[["sysname"]]) == "windows") {
+ if (tolower(Sys.info()[["sysname"]]) %in% c("windows", "darwin")) {
data <- data[-c(1, 3), ]
}
}